Use tagged buildpack-deps #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is unneeded now that buildpack-deps pulls these in via its own `buildpack-deps:curl` and `buildpack-deps:scm` base images.
Enable specifying what `buildpack-deps` tagged image to use on Perl image builds, defaulting to `stretch` at this time.
This lets us build older Perls on their contemporary build stack.
Thanks generate.pl!
We don't need `mkdir` since COPY will already make the destination path for us.
|
😍 this is good stuff 👍 |
|
@PeterMartini let me merge this in for image update :) |
zakame
added a commit
to zakame/docker-library-official-images
that referenced
this pull request
Aug 26, 2017
- tagged buildpack-deps (Perl/docker-perl#35) - more secure installation of cpanm (Perl/docker-perl#41) - arm64v8 support (Perl/docker-perl#38)
This was referenced Aug 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
buildpack-depsoption that lets us specify what tag to use onbuilding Perl images. This can then let us build older Perls (<5.20)
against their contemporary build stack.
Fixes #34.