Skip to content

Conversation

@akonale
Copy link

@akonale akonale commented Jan 22, 2018

This is to support hiveclient in oozie using delegation tokens. Internally delegation token authentication is done using DIGEST-MD5 sasl mechanism. And the parameters are passed using the username, password extracted from delegation token. Also removed hardcoding of service names, which should be ideally read from kerberos principal in case of GSSAPI auth, and specifically set to null in case of DIGEST auth.

davecardwell and others added 3 commits April 13, 2017 10:06
I’ve been seeing the following error when a script exits:

> (in cleanup) Can't call method "close" on an undefined value at /home/lpadm/.perl5/perlbrew/perls/perl-5.24.1/lib/site_perl/5.24.1/Thrift/API/HiveClient2.pm line 499 during global destruction.

This commit ensures that `$self->_transport` exists before attempting to call the `close` method.
Don’t try to close undefined transport during global destruction
Copy link
Member

@burak burak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as Thrift::SASL, please set principal to nothing by default as this default REALM.COM is not useful. Also guard the option passing by checking if it has a value. Also note the argument position change requested in the ::SASL code.

@akonale
Copy link
Author

akonale commented Jan 23, 2018

Hi,
Feedback changes have been incorporated. Could you please reveiw it ?
Thanks

@burak burak merged commit 1c6fb50 into Perl-Hadoop:master Jan 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants