Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete Chinese Translation of README.md #68

Merged
merged 6 commits into from
Nov 2, 2024

Conversation

SheepChef
Copy link
Contributor

Changes

Add elaborated Chinese Translation of README.md

Why

Chinese Translation is important considering the number of its speakers.

Checkmarks

  • The modified functions have been tested.
  • Used the same indentation as the rest of the project.
  • Updated documentation (changelog).

Additional information

It is worth noticing that the previous PR involves multiple tedious expressions.

I am specialized in EN-CN translating, so feel free to give me some suggestions.

Signed-off-by: SheepChef <50871867+SheepChef@users.noreply.github.com>
Signed-off-by: SheepChef <50871867+SheepChef@users.noreply.github.com>
Signed-off-by: SheepChef <50871867+SheepChef@users.noreply.github.com>
Signed-off-by: SheepChef <50871867+SheepChef@users.noreply.github.com>
Copy link

@R917C R917C left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comments

README_CN.md Show resolved Hide resolved
README_CN.md Show resolved Hide resolved
README_CN.md Outdated Show resolved Hide resolved
@SheepChef
Copy link
Contributor Author

SheepChef commented Oct 29, 2024

Changes performed in translation are reasonable and logical to make the meaning clearer.

Some arguments were solved by asking the maintainer.

I could say it's ready to merge 🆗

Copy link

@R917C R917C left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then, perfect

Add a space between ZygiskNext.
Adjust some words after assessment to make it more accurate and faithful.
@Keeperorowner
Copy link
Contributor

应该没啥问题,可以合并
l think no problem,recommend to merge

@ThePedroo
Copy link
Member

I think it would be better to move it to a "READMEs" folder. Also please remove "Better standalone hiding" from English one, to match Chinese one. After that it's okay.

@SheepChef
Copy link
Contributor Author

I think it would be better to move it to a "READMEs" folder. Also please remove "Better standalone hiding" from English one, to match Chinese one. After that it's okay.

So do I need to create a folder called READMEs? Or may you perform the action later?

Signed-off-by: SheepChef <50871867+SheepChef@users.noreply.github.com>
@SheepChef
Copy link
Contributor Author

I think it would be better to move it to a "READMEs" folder. Also please remove "Better standalone hiding" from English one, to match Chinese one. After that it's okay.

Content removed, if creating a folder tends to be done by you, then it's ready.

@ThePedroo ThePedroo merged commit 7027e81 into PerformanC:main Nov 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants