Re-write Zygiskd #38
Closed
Re-write Zygiskd #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit re-writes Zygiskd to be C99.
This commit adds the first base for C99 zygiskd, that is not fully working or code-ready.
ThePedroo
added
enhancement
This commit both improves the code readability and also fixes a bug that wouln't start companions properly.
This commit will have a rebase soon.
3 tasks
3 tasks
3 tasks
3 tasks
2 tasks
This commit fixes building process of new zygiskd.
ThePedroo
force-pushed
the
add/zygiskd-c99
branch
from
d308e09
to
c6d5176
Compare
This commit removes the setup of Rust in the CI.
This commit improves the compilation commands resulting in even better sized releases.
ThePedroo
force-pushed
the
add/zygiskd-c99
branch
from
edf4d6a
to
e79a695
Compare
This commit corrects mount namespace code.
ThePedroo
force-pushed
the
add/zygiskd-c99
branch
from
31a6b04
to
c0463af
Compare
This commit fixes the conflicts between "main" and "add/zygiskd-c99".
ThePedroo
force-pushed
the
add/zygiskd-c99
branch
from
c0463af
to
b6c83c0
Compare
This commit improves the code that calls the compiler to compile zygiskd.
This commit fixes the use of fgets in a file descriptor, which would make it easier to use fopen instead of using fdopen.
This commit fixes the building of zygiskd.
This commit fixes the segmentation fault when trying to write to /proc/.../sockcreate.
3 tasks
ThePedroo
force-pushed
the
add/zygiskd-c99
branch
from
2e1dbdc
to
62ce581
Compare
This commit adds support for zygiskd C99 to recognize APatch rooted devices.
This commit adds Magisk support to Zygiskd C99, and also fixes some code issues of it.
|
Nice |
This commit updates the LICENSE for Zygiskd C99, using a LICENSE that doesn't allow the code to be used for closed source projects, and with more restrictions while allowing other people to fork, modify as much as wanted as long as it remains open source.
ThePedroo
force-pushed
the
add/zygiskd-c99
branch
from
fd21c63
to
6fe5846
Compare
This commit removes the logging made to the zygiskd.log file.
This commit fixes some few UBs (Undefined Behaviors) based on numerous sanitizers, and also adds the missing error handling for a "malloc" call.
This commit improves Zygisk's build gradle file by avoiding the repetition of compiler flags.
ThePedroo
force-pushed
the
add/zygiskd-c99
branch
from
e190259
to
1488ce7
Compare
This commit improves the robustness of the code by removing debug logs, fixing a memory leak, and adding missing error handling.
Signed-off-by: Pedro.js <pedroolimpioguerra@gmail.com>
ThePedroo
force-pushed
the
add/zygiskd-c99
branch
from
20cc738
to
25ee940
Compare
This commit fixes compiling errors from missing declaration of variables and missing macros.
This commit removes logging used in development, which is not needed anymore.
ThePedroo
force-pushed
the
add/zygiskd-c99
branch
from
e1d9fe9
to
69d09ea
Compare
This commit fixes the Magisk part of Zygiskd C99 which used to mark all apps as outside DenyList.
This commit improves the spacing of the module status description.
This commit adds the Magisk variant to module description, and also improves KernelSU detection by requiring the userspace part of it to be installed, AKA "ksud".
|
Zdendaop
approved these changes
Oct 26, 2024
This commit fixes a memory leak and a user-after-free vulnerability in APatch code of Zygiskd.
This commit fixes the module name in Zygiskd log which would only show a letter.
This commit improves the Zygiskd Magisk code by avoiding redundant code and reducing complexity.
This commit fixes the value of the macro that defines the size of the longest root implementation name, leading to Zygiskd crashes on Magisk Official.
This commit fixes both fd leak and out-of-bounds access in the "exec_command" function, which can happen when execution of the command fails, leading to crashes on Magisk-rooted devices, and possibly APatch-rooted devices too.
This commit both fixes a possible out-of-bounds write by using "snprintf" over "sprintf" and also removes a unnecessary logging which was meant to be removed commits ago.
This commit both improves the code that parses "module.prop" file of ReZygisk, reducing its complexity greatly and also making it smaller, and also fixes an issue where ReZygisk would deference a NULL pointer, leading to crashes in Zygiskd crash.
This commit fixes the issue where some loggings would add an additional new line.
This commit fixes the space indentation done in the "ASSURE_*" macros.
ThePedroo
added
confirmed
|
Landed on 97af7fe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR focus on the change of zygiskd from Rust to C99.
Why
C99 has been proven to be a more robust and future-proof language, also being more performant and capable.
Checkmarks
Additional information
Also will allow the use of multiple root implementation by just ignoring deny list.