Skip to content
This repository was archived by the owner on Jul 14, 2022. It is now read-only.
This repository was archived by the owner on Jul 14, 2022. It is now read-only.

TinyMCE 4 #50

@PerfectlyNormal

Description

@PerfectlyNormal

Tracking progress for TinyMCE 4 compatibility in a separate issue.

Done

  • It doesn't seem to actually submit the values in the form
  • Dialog misses styling
  • Spinner (throbber) doesn't work. It gets appended, but the automatic height calculating has already given the container height: 0px;
  • Should see if it's possible to drop dialog.html and use the new way of creating dialogs (had trouble getting a <input type='file'> in there)
  • Icon needs to be improved (Icon should be a vector image #37)
  • Should add the action to the menu bar as well as the button bar
  • Make sure the hint and authentication_token still gets submitted
  • Support POSTing to configurable path
  • form drops the name attribute on our inputs
  • Parse response and insert the image
  • Pressing enter while in the form should submit it properly, not just close the window
  • Inserted image gets the wrong alt-text
  • Error handling is absent
  • Don't submit without an image
  • README talks about uploadimage_default_img_class, so keep that working
  • Get the form not looking like ass (inputs float everywhere)
  • Drop the border around the file input
  • Preload the throbber so we don't have to wait for it

Waiting

  • Test precompiling under Rails 3.2 and 4, since that tends to be a mess

Release preparations

  • Clean up the code
  • Extensive testing in IE8+, Firefox, Safari, Chrome and others we might care about
  • I have no idea how to fix proper automated tests for this, or what to test, but we should have some…
  • Make a proper beta release

Some of these probably work, but haven't been tested just yet.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions