This repository was archived by the owner on Aug 19, 2021. It is now read-only.
PMM-4949 RDS Management API. #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
…pmm-api-tests into PMM-4949-management
golangcibot
reviewed
Nov 28, 2019
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| func TestRDSDiscovery(t *testing.T) { |
There was a problem hiding this comment.
func TestRDSDiscovery is unused (from unused)
| }) | ||
| } | ||
|
|
||
| func TestAddRds(t *testing.T) { |
There was a problem hiding this comment.
func TestAddRds is unused (from unused)
| "time" | ||
|
|
||
| "github.com/AlekSi/pointer" | ||
| pmmapitests "github.com/Percona-Lab/pmm-api-tests" |
There was a problem hiding this comment.
File is not goimports-ed with -local github.com/Percona-Lab/pmm-api-tests (from goimports)
Suggested change
| pmmapitests "github.com/Percona-Lab/pmm-api-tests" |
| t.Run("Basic", func(t *testing.T) { | ||
| accessKey, secretKey := os.Getenv("AWS_ACCESS_KEY"), os.Getenv("AWS_SECRET_KEY") | ||
| if accessKey == "" || secretKey == "" { | ||
| // TODO remove skip once secrets are added |
There was a problem hiding this comment.
management/rds_test.go:21: Line contains TODO/BUG/FIXME: "TODO remove skip once secrets are added" (from godox)
| require.NotNil(t, discoverOK.Payload) | ||
| assert.NotEmpty(t, discoverOK.Payload.RDSInstances) | ||
|
|
||
| // TODO Better tests: https://jira.percona.com/browse/PMM-4896 |
There was a problem hiding this comment.
management/rds_test.go:37: Line contains TODO/BUG/FIXME: "TODO Better tests: https://jira.percona...." (from godox)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.