Refactor data generator runner into exported package #29
+412
−388
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to be able to use most of the functionality of this tool as a package we can import into other Go binaries, so this refactors the
run()
function from the main package into agenerator
package that can be imported and used. SinceRun()
still takes the same arguments, several of which are custom types that are non-trivial to recreate by the caller, the methods main uses to create those parameters of callingRun()
are also extracted out to the newgenerate
package as they are part of the data generation process.The existing test cases seem to cover the critical functionality here to ensure it's not breaking. I will also be testing this branch internally with our own tools to ensure we can call the
generator.Run()
method as expected.