Skip to content

Refactor data generator runner into exported package #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adregner
Copy link

We want to be able to use most of the functionality of this tool as a package we can import into other Go binaries, so this refactors the run() function from the main package into a generator package that can be imported and used. Since Run() still takes the same arguments, several of which are custom types that are non-trivial to recreate by the caller, the methods main uses to create those parameters of calling Run() are also extracted out to the new generate package as they are part of the data generation process.

The existing test cases seem to cover the critical functionality here to ensure it's not breaking. I will also be testing this branch internally with our own tools to ensure we can call the generator.Run() method as expected.

@adregner
Copy link
Author

I guess I should note that I ran the tests on this personally and they all passed but the automated test suite seems to just be broken in master outside of the context of this refactor. PR #28 (accidentally) fixes the RandomBinary issue at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant