Fix upload stall error introduced with S3 throttle #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A `break` statement was accidentally unindented one level too far, introducing a bug when looking for multipart upload ids. That led to multipart chunks being missed and the overall upload never finishing. Also: Increase the number of callbacks for throttling, because on very fast connections the previous block size of 2MB was to coarse.
timvaillancourt
approved these changes
Dec 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
breakstatement was accidentally unindented one leveltoo far, introducing a bug when looking for multipart
upload ids. Sorry for that :)
It led to multipart chunks being missed and the overall
upload never finishing. Throw an error in case the multipart
upload is not found on S3 anymore, for example due to
manual aborts with the AWS CLI tool.
In these cases the backup could hang forever, too.
Also: Increase the number of callbacks for throttling,
because on very fast connections the previous block
size of 2MB was to coarse.