Skip to content

1.21.5 - Some functionallity #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: 1.21.4/dev
Choose a base branch
from

Conversation

litetex
Copy link

@litetex litetex commented Apr 20, 2025

This is a PoC showcasing some work that I did to get some basic functionality (connected textures) working with 1.21.5.
It might help with updating the complete mod to 1.21.5.

Please note that I'm not committed to implement the still missing functionality, so don't wait for this PR to be finished.

What is NOT working / still needs to be done

  • Emissive textures (1.21.5 changed a lot of the corresponding code)
  • Some optimizations can likely be done. For example there are no longer any block-states used. The code for this can be removed and caching may be applied.
  • FallingBlockEntityRendererMixin is incompatible with Fabric-API's version of it. Currently the relevant code was copied over.

Already done

  • Updated various (dependency) versions
  • Connected textures
    Screenshot

Download

Pre-built JARs are available from: https://github.com/litetex/Continuity/actions/workflows/build.yml?query=branch%3A1.21.5%2Fdev

Direct download link

Use at your own risk.

@PepperCode1
Copy link
Owner

Thanks for your efforts, but most relevant changes in this pull request I have already made locally since I made a test build for the Discord a few days ago.

However, I am interested by what you mean by

Some optimizations can likely be done. For example there are no longer any block-states used. The code for this can be removed and caching may be applied.

@litetex
Copy link
Author

litetex commented Apr 20, 2025

@PepperCode1
Thank you for the quick response.

Thanks for your efforts, but most relevant changes in this pull request I have already made locally since I made a test build for the Discord a few days ago.

Okay, I was not aware of this.

How about using the Git repo instead?

  • That way also your PC can exploded and your work is still saved (one of the main points why Git is used in the first place)
  • GitHub Actions can build the code automatically and so it's not a "trust me" JAR from Discord

However, I am interested by what you mean by

Some optimizations can likely be done...

So for example:

@PepperCode1
Copy link
Owner

I agree using Git even for WIP code would be better. I'll try to do that more going forward.

The default state and default slice func system exist to make that path run faster than accessing the global cache every time, since the default state is used almost all the time. However, edge cases are possible when the model is invoked by another model with a different state or the block has a custom appearance. The state will not match the default state in these cases, so the slice func for the current state should be retrieved from the global cache. I don't see how 1.21.5 changes the need for this system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants