-
Notifications
You must be signed in to change notification settings - Fork 620
Make nxc compatible with bloodhound-ce zip #664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Or another solution is to embrace bloodhound-ce and just use it and drop legacy bloodhound (i prefer this solution but the pr offer both choice in case) |
Honestly, i would switch to bloodhound-ce as well. What about we give the user the choice to switch back to the old bloodhound version with this tutorial/fix, but use bloodhound-ce as default? Thoughts? |
A bit of a late response, but I agree with this solution. I don't think NetExec should break backwards compatibility, but considering that Bloodhound CE is now the default version included with the latest version of Kali, I think using the CE collector by default is the right move. |
|
Bloodhound-ce is now the default package |
Signed-off-by: mpgn <5891788+mpgn@users.noreply.github.com>
Signed-off-by: mpgn <5891788+mpgn@users.noreply.github.com>
NeffIsBack
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: mpgn <5891788+mpgn@users.noreply.github.com>

Description
This PR allow a user to dump using bloodhound-ce or bloodhound, it's a bit manuel but no choice.
This is a bit related to #616 and #663 , ippsec and 0xdf are both using bloodhound-ce package directly since the one on nxc doesn't supporte the community edtion :'(
Maybe bloodhound-ce should be the default pacakage now ... 🤔
This pull request introduces enhancements for managing BloodHound configurations and handling compatibility between the standard and Community Edition (CE) versions. The changes include adding a new configuration section, implementing a utility function to detect BloodHound versions, and improving error handling for mismatched configurations.
BloodHound Configuration Enhancements:
New Configuration Section for BloodHound-CE: Added a
[BloodHound-CE]section in thenxc.conffile to enable or disable the Community Edition. (nxc/data/nxc.conf)Utility Function to Detect Installed BloodHound Version: Introduced
get_bloodhound_infoto determine the installed BloodHound package (bloodhoundorbloodhound-ce), its version, and whether it is the CE version. (nxc/protocols/ldap.py)Configuration Validation and Error Handling: Added logic to validate the configuration against the installed BloodHound version, providing detailed error messages and remediation steps if there is a mismatch. (
nxc/protocols/ldap.py)Code Quality Improvements:
bloodhoundmethod to returnNoneinstead of an implicitNonewhen no collection methods are resolved. (nxc/protocols/ldap.py)Type of change
How Has This Been Tested?
Against vintage box
Screenshots (if appropriate):
Checklist:
poetry run python -m ruff check . --preview, use--fixto automatically fix what it can)