Refactor is_host_dc call based on file generation flags#1097
Open
Refactor is_host_dc call based on file generation flags#1097
Conversation
Conditionally call is_host_dc based on arguments for generating files. Signed-off-by: mpgn <5891788+mpgn@users.noreply.github.com>
NeffIsBack
requested changes
Feb 7, 2026
Signed-off-by: mpgn <5891788+mpgn@users.noreply.github.com>
Collaborator
Author
|
should be better @NeffIsBack ! |
NeffIsBack
reviewed
Feb 8, 2026
Change isdc initialization from False to None and update related checks. Signed-off-by: mpgn <5891788+mpgn@users.noreply.github.com>
Signed-off-by: mpgn <5891788+mpgn@users.noreply.github.com>
Collaborator
Author
|
done, let me know what you think @NeffIsBack :) |
NeffIsBack
approved these changes
Feb 8, 2026
Member
NeffIsBack
left a comment
There was a problem hiding this comment.
Looks good, let's go with this👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conditionally call is_host_dc based on arguments for generating files.
Description
This pull request introduces a small but important change to the logic for determining whether to call the
is_host_dc()method in theenum_host_infofunction innxc/protocols/smb.py. The update ensures thatis_host_dc()is only called under specific conditions related to the generation of hosts or krb5 files.Key logic update:
is_host_dc()is now conditioned to only run if eithergenerate_hosts_fileorgenerate_krb5_filearguments are set, or if neither is set, ensuring more precise control over when domain controller detection occurs. [1] [2]Type of change
Insert an "x" inside the brackets for relevant items (do not delete options)
Setup guide for the review
Screenshots (if appropriate):
Checklist:
Insert an "x" inside the brackets for completed and relevant items (do not delete options)
poetry run python -m ruff check . --preview, use--fixto automatically fix what it can)tests/e2e_commands.txtfile if necessary (new modules or features are required to be added to the e2e tests)