Add MultiTemporaryAND operation as Operation class#9379
Draft
Add MultiTemporaryAND operation as Operation class#9379
Conversation
Contributor
|
Hello. You may have forgotten to update the changelog!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
This operation is ubiquitous in many subroutines, makes sense to not have to re-code it
In #9321 tried to make
MultiTemporaryANDinherit fromControlledOp, similarly to howMultiCtrontrolledXis constructed. Trying to avoid the same design flaws and construct the operation here by inheriting fromOperation(more similar to whatTemporaryANDis doing).Description of the Change:
Benefits:
Simplifying, unifying and improving a lot of subroutines in the code base
Possible Drawbacks:
Another op/subroutine to maintain 🚧
Related GitHub Issues: