[WIP] Upgrade TemporaryAND to handle multiple control wires#9357
Draft
[WIP] Upgrade TemporaryAND to handle multiple control wires#9357
Conversation
Qottmann
added
the
do not merge ⚠️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
Just exploring an idea here. This has not been approved or discussed with product yet, as I am not even sure myself, if this is the best solution.
We often need to decompose control structure into multiple TemporaryAND (A TemporaryAND ladder if you will). It makes sense to extend TemporaryAND to have multiple control wires + work wires.
Description of the Change:
Extending TemporaryAND to multiple wires, adding an efficient decomposition when work wires are provided.
Benefits:
Efficient decomposition and this subroutine appears in almost all arithmetic operations (essentially, whenever there is multi-control). Unifying this into a single op that can be used in multiple places heavily reduces maintence burden and also ensures we use the best possible decomposition of multi-controlled ops everywhere in pennylane.
Further enables an efficient decomposition of
C(Prod)(follow-up)Possible Drawbacks:
The current implementation does not work yet (WIP)
Drawback from going to ControlledOp ->
control_valuesare not jittable (this is, however, resolved elsewhere). The only reason TemporaryAND had jittablecontrol_valueswas because they were manualy inserted despite the operator not being a ControlledOp.The current version is not introducing breaking changes.
Related GitHub Issues: