[qml->qp] data / pytrees module#9333
Conversation
gabrielasd
left a comment
gabrielasd
left a comment
There was a problem hiding this comment.
I looked at the rendered doc for qp.data and followed a few of the hyperlinks. It looks good to me
andrijapau
added
the
qml->qp migration
**Context:** Fallback handling for data module **Description of the Change:** **Benefits:** **Possible Drawbacks:** **Related GitHub Issues:**
comp-phys-marc
added
the
review-ready 👌
This reverts commit 113bac8.
andrijapau
left a comment
andrijapau
left a comment
There was a problem hiding this comment.
Sorry for the delay, but I was doing some due diligence to make sure the changes here don't impact anything. Just some comments.
| return None | ||
|
|
||
| def __delitem__(self, __name: str) -> None: | ||
| del self.attrs_bind[self.bind_key(__name)] |
There was a problem hiding this comment.
Won't this be affected too?
There was a problem hiding this comment.
@obliviateandsurrender are you able to comment?
There was a problem hiding this comment.
Let me check in a bit and see if it needs patching.
There was a problem hiding this comment.
@obliviateandsurrender , do you know if these changes also impact anything in the datasets module?
There was a problem hiding this comment.
They might with the pytree serialization. I will test them and include them in my PR as well.
There was a problem hiding this comment.
Thank you so much! 🙏🏼 🙌🏼
There was a problem hiding this comment.
Opened the PR, will tag you guys when it is ready for your review!
andrijapau
added
the
do not merge ⚠️
andrijapau
changed the title
data / pytrees module qml->qpdata / pytrees module
andrijapau
removed
the
review-ready 👌
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9333 +/- ##
=======================================
Coverage 99.44% 99.44%
=======================================
Files 610 610
Lines 66958 66965 +7
=======================================
+ Hits 66586 66594 +8
+ Misses 372 371 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4 participants
Context: We would like to update a number of PennyLane modules to import pennylane as
qpand to useqpinstead ofqmlthroughout. This is a part of a wider rebrand of the package.Description of the Change: Updates names, imports and references to
qml.Benefits: Updated to the new branding.
Possible Drawbacks: Requires updates to the datasets from the Cloud team.
Related GitHub Issues: [sc-117238]