Bucket brigade QRAM#8670
Merged
Merged
Conversation
Contributor
Author
|
Hi @isaacdevlugt most of these failures in CI are due to your TODOs w.r.t. the visuals, etc. Any chance you can help me address these? Otherwise, I can ask IT if I can install inkscape and whip something up. |
JerryChen97
reviewed
Nov 27, 2025
Co-authored-by: Yushao Chen (Jerry) <chenys13@outlook.com>
Co-authored-by: Yushao Chen (Jerry) <chenys13@outlook.com>
isaacdevlugt
left a comment
isaacdevlugt
left a comment
Contributor
There was a problem hiding this comment.
Hey @comp-phys-marc! I changed the qram_wires arg to control_wires, which matches QROM.
The tests will fail because I changed raise ValueError("len(bitstrings) must be 2^(len(control_wires)).") 😈
Contributor
Author
Thanks, I'll go through and see where the references to this param need updating now. |
Co-authored-by: Isaac De Vlugt <34751083+isaacdevlugt@users.noreply.github.com>
Co-authored-by: Isaac De Vlugt <34751083+isaacdevlugt@users.noreply.github.com>
JerryChen97
approved these changes
Nov 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: As discussed earlier today with the team from Yale, we would like to start by solidifying just the classic bucket-brigade QRAM implementation.
Description of the Change: Adds a template to
qram.pythat moves and solidifies the classic BBQRAM implementation fromqramv1.pyonly. Applies all the changes suggested by @isaacdevlugt to the call signature, docs, etc. and adds a few test cases.Benefits: The classic BBQRAM implementation is a bit more mature.
Possible Drawbacks: The hybrid and SELECT-only implementations are still left as WIPs.
Related GitHub Issues: [sc-103834]