Skip to content

update pylint, isort and black versions in format.yml #8506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 45 commits into from
Oct 24, 2025
Merged

update pylint, isort and black versions in format.yml #8506

merged 45 commits into from
Oct 24, 2025

Conversation

@andrijapau
Copy link
Contributor

@andrijapau andrijapau commented Oct 20, 2025 •
edited
Loading

Time to bump the linting and formatting eco-system again.

@github-actions

This comment was marked as resolved.

Sign in to view
andrijapau
andrijapau commented Oct 20, 2025
View reviewed changes
comp-phys-marc
comp-phys-marc requested changes Oct 22, 2025
View reviewed changes
Copy link
Contributor

@comp-phys-marc comp-phys-marc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Just not exactly sure about some of the typing changes.

@andrijapau andrijapau added the do not merge ⚠️ Do not merge the pull request until this label is removed label Oct 22, 2025
@comp-phys-marc
Copy link
Contributor

If you inspect each of these instances you are changing to classes and classes you are changing to instances and can tell me that the types were wrong before, verified by inspection, then I will be ready to approve.

JerryChen97
JerryChen97 reviewed Oct 22, 2025
View reviewed changes
JerryChen97
JerryChen97 reviewed Oct 22, 2025
View reviewed changes
Copy link
Contributor

@JerryChen97 JerryChen97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM! Let's see more context about the data thing and re-request me when it's no problem

@JerryChen97 JerryChen97 mentioned this pull request Oct 23, 2025
Merged
andrijapau
andrijapau commented Oct 24, 2025
View reviewed changes
andrijapau
andrijapau commented Oct 24, 2025
View reviewed changes
andrijapau
andrijapau commented Oct 24, 2025
View reviewed changes
andrijapau
andrijapau commented Oct 24, 2025
View reviewed changes
andrijapau
andrijapau commented Oct 24, 2025
View reviewed changes
andrijapau
andrijapau commented Oct 24, 2025
View reviewed changes
andrijapau
andrijapau commented Oct 24, 2025
View reviewed changes
comp-phys-marc
comp-phys-marc approved these changes Oct 24, 2025
View reviewed changes
Copy link
Contributor

@comp-phys-marc comp-phys-marc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for inspecting those types!

JerryChen97
JerryChen97 approved these changes Oct 24, 2025
View reviewed changes
Copy link
Contributor

@JerryChen97 JerryChen97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@andrijapau andrijapau removed the do not merge ⚠️ Do not merge the pull request until this label is removed label Oct 24, 2025
@andrijapau andrijapau added this pull request to the merge queue Oct 24, 2025
Merged via the queue into master with commit a047c55 Oct 24, 2025
54 checks passed
@andrijapau andrijapau deleted the sc-101550/bump-pylint-black-isort branch October 24, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Alex-Preciado Alex-Preciado Alex-Preciado left review comments

@JerryChen97 JerryChen97 JerryChen97 approved these changes

@comp-phys-marc comp-phys-marc comp-phys-marc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andrijapau @comp-phys-marc @JerryChen97 @Alex-Preciado