Skip to content

Conversation

@comp-phys-marc
Copy link
Contributor

Context: QuantumScript.to_openqasm was previously deprecated and planned to be removed in 0.44.

Description of the Change: Removes QuantumScript.to_openqasm and associated test.

Benefits: No longer has two entry points for this functionality.

Possible Drawbacks: Mitiq needs to update to use the new qml.to_openqasm, but they plan to in their next release.

Related GitHub Issues: unitaryfoundation/mitiq#2814

Related ShortCut Stories: [sc-101311]

@comp-phys-marc comp-phys-marc marked this pull request as ready for review October 20, 2025 19:08
Copy link
Contributor

@JerryChen97 JerryChen97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update the deprecations.rst as well!

	- Move to completed section
Copy link
Contributor

@JerryChen97 JerryChen97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

	- Debug AWS outage
@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.42%. Comparing base (78a0bae) to head (9a472c1).
⚠️ Report is 26 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8499   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files         583      585    +2     
  Lines       61234    61305   +71     
=======================================
+ Hits        60881    60954   +73     
+ Misses        353      351    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@comp-phys-marc comp-phys-marc requested review from gabrielasd and removed request for isaacdevlugt October 21, 2025 18:12
@comp-phys-marc comp-phys-marc added the do not merge ⚠️ Do not merge the pull request until this label is removed label Oct 23, 2025
@comp-phys-marc
Copy link
Contributor Author

Going to hold off untl Mitiq 0.48.0 is released to merge this one.

Copy link
Contributor

@gabrielasd gabrielasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not merge ⚠️ Do not merge the pull request until this label is removed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants