-
Notifications
You must be signed in to change notification settings - Fork 705
Removal of QuantumScript.to_openqasm #8499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's update the deprecations.rst as well!
- Move to completed section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
- Debug AWS outage
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8499 +/- ##
=======================================
Coverage 99.42% 99.42%
=======================================
Files 583 585 +2
Lines 61234 61305 +71
=======================================
+ Hits 60881 60954 +73
+ Misses 353 351 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Going to hold off untl Mitiq 0.48.0 is released to merge this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Context:
QuantumScript.to_openqasmwas previously deprecated and planned to be removed in 0.44.Description of the Change: Removes
QuantumScript.to_openqasmand associated test.Benefits: No longer has two entry points for this functionality.
Possible Drawbacks: Mitiq needs to update to use the new
qml.to_openqasm, but they plan to in their next release.Related GitHub Issues: unitaryfoundation/mitiq#2814
Related ShortCut Stories: [sc-101311]