-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding qml.Superposition
#6670
Adding qml.Superposition
#6670
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6670 +/- ##
=========================================
Coverage ? 99.62%
=========================================
Files ? 475
Lines ? 44715
Branches ? 0
=========================================
Hits ? 44546
Misses ? 169
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just some minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @KetpuntoG, left some comments but looks good overall.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @KetpuntoG, left my final set of comments, will approve when they are addressed.
Co-authored-by: Soran Jahangiri <40344468+soranjh@users.noreply.github.com>
Thanks for the review @soranjh , I worked on the changes and added the checks. Note that the normalization check, verify that we are not with an abstract input, otherwise it doesn't work with jit (same as other templates) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks @KetpuntoG.
Co-authored-by: Soran Jahangiri <40344468+soranjh@users.noreply.github.com>
Co-authored-by: Soran Jahangiri <40344468+soranjh@users.noreply.github.com>
**Context:** This PR implements `qml.Superposition,` a new operator that prepares states given as superposition of basic states [sc-72648] **Benefits:** Allow user to prepare states in a new format In addition, the decomposition is efficient for this type of states **Possible Drawbacks:** --------- Co-authored-by: Soran Jahangiri <40344468+soranjh@users.noreply.github.com>
Context:
This PR implements
qml.Superposition,
a new operator that prepares states given as superposition of basic states[sc-72648]
Benefits:
Allow user to prepare states in a new format
In addition, the decomposition is efficient for this type of states
Possible Drawbacks: