-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added TrotterizedQfunc
operation
#6627
Conversation
Hello. You may have forgotten to update the changelog!
|
[sc-72601] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Here are a few comments.
Co-authored-by: Christina Lee <christina@xanadu.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Jaybsoni, left some comments, will approve after that.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6627 +/- ##
==========================================
- Coverage 99.64% 99.64% -0.01%
==========================================
Files 469 468 -1
Lines 44331 44125 -206
==========================================
- Hits 44173 43967 -206
Misses 158 158 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changelog?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments, approved once they are addressed 🙂
Co-authored-by: Diego <67476785+DSGuala@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks :)
We can have a follow up to integrate this with capture, since it might be a bit more difficult.
Thanks @Jaybsoni! Can you please link the Shortcut story to this PR? 🙏 |
Context:
One of the results from Discovery work in Product formulas was the need to generalize the
TrotterProduct
class such that it can work on exponentiated operators directly instead of system hamiltonians. This was to support the Compressed Double Factorization (CDF) technique on hamiltonians.Description of the Change:
TrotterizedQfunc
classtrotterize
functionBenefits:
TrotterProduct
class to the case where we have oracle access to the exponentiated terms of the hamiltonian.Possible Drawbacks:
Related GitHub Issues:
None