Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added TrotterizedQfunc operation #6627

Merged
merged 39 commits into from
Dec 9, 2024
Merged

Added TrotterizedQfunc operation #6627

merged 39 commits into from
Dec 9, 2024

Conversation

Jaybsoni
Copy link
Contributor

@Jaybsoni Jaybsoni commented Nov 22, 2024

Context:
One of the results from Discovery work in Product formulas was the need to generalize the TrotterProduct class such that it can work on exponentiated operators directly instead of system hamiltonians. This was to support the Compressed Double Factorization (CDF) technique on hamiltonians.

Description of the Change:

  • Added new TrotterizedQfunc class
  • Added new trotterize function

Benefits:

  • Allows users to perform product formula based hamiltonian simulation on CDF hamiltonians.
  • Generalizes the TrotterProduct class to the case where we have oracle access to the exponentiated terms of the hamiltonian.

Possible Drawbacks:

  • Not sure how well it plays with program capture
  • Not sure how well it integrates with catalyst and jax.jit

Related GitHub Issues:
None

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@Jaybsoni
Copy link
Contributor Author

[sc-72601]

Copy link
Contributor

@willjmax willjmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Here are a few comments.

Copy link
Contributor

@soranjh soranjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Jaybsoni, left some comments, will approve after that.

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.64%. Comparing base (c5fd5bc) to head (c142695).
Report is 285 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6627      +/-   ##
==========================================
- Coverage   99.64%   99.64%   -0.01%     
==========================================
  Files         469      468       -1     
  Lines       44331    44125     -206     
==========================================
- Hits        44173    43967     -206     
  Misses        158      158              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@albi3ro albi3ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog?

Copy link
Contributor

@DSGuala DSGuala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, approved once they are addressed 🙂

@Jaybsoni Jaybsoni requested a review from albi3ro December 9, 2024 19:02
Copy link
Contributor

@albi3ro albi3ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

We can have a follow up to integrate this with capture, since it might be a bit more difficult.

@Jaybsoni Jaybsoni merged commit 47a814e into master Dec 9, 2024
46 checks passed
@Jaybsoni Jaybsoni deleted the new_trotterize branch December 9, 2024 20:01
@PietropaoloFrisoni
Copy link
Contributor

Thanks @Jaybsoni! Can you please link the Shortcut story to this PR? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review-ready 👌 PRs which are ready for review by someone from the core team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants