Support the construction of bosonic operators #6518

austingmhuang · 2024-11-05T16:33:28Z

Context:
We need BoseWords and BoseSentences to help us build vibrational hamiltonians.

Description of the Change:
Add BoseWords and BoseSentences

Benefits:

Possible Drawbacks:

Related GitHub Issues:
[sc-72640]

github-actions · 2024-11-05T16:33:42Z

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

A one-to-two sentence description of the change. You may include a small working example for new features.
A link back to this PR.
Your name (or GitHub username) in the contributors section.

ddhawan11

Thanks @austingmhuang. A couple of minor comments from me.

pennylane/labs/vibrational_ham/bosonic.py

Co-authored-by: Diksha Dhawan <40900030+ddhawan11@users.noreply.github.com>

soranjh

Thanks @austingmhuang, left some comments. The test file seems to be incomplete.

pennylane/labs/tests/vibrational_ham/test_bosonic.py

pennylane/labs/vibrational_ham/__init__.py

pennylane/labs/vibrational_ham/bosonic.py

pennylane/labs/tests/vibrational_ham/test_bosonic.py

Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>

doc/releases/changelog-dev.md

pennylane/qchem/vibrational/bosonic.py

doc/releases/changelog-dev.md

obliviateandsurrender

Looks good, just some optional comments.

doc/releases/changelog-dev.md

pennylane/qchem/vibrational/bosonic.py

tests/qchem/vibrational_tests/test_bosonic.py

Co-authored-by: Utkarsh <utkarshazad98@gmail.com>

ddhawan11

Good to go from my side, good work @austingmhuang

doc/releases/changelog-dev.md

Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>

DSGuala

Nice work! Looks good overall.

I'm wondering whether qml.qchem.BoseWord should be qml.bose.BoseWord for consistency with qml.fermi.FermiWord. Not a blocker.

I had some trouble with arithmetic, but the tests are passing, so maybe it's something on my end?

tests/qchem/vibrational_tests/test_bosonic.py

austingmhuang · 2024-11-21T19:11:59Z

I'm wondering whether qml.qchem.BoseWord should be qml.bose.BoseWord for consistency with qml.fermi.FermiWord. Not a blocker.

Hmmm.... this is kind of a good point actually. @soranjh I think it is fine in qchem personally, but do you think this should be changed?

soranjh · 2024-11-21T19:22:44Z

I'm wondering whether qml.qchem.BoseWord should be qml.bose.BoseWord for consistency with qml.fermi.FermiWord. Not a blocker.

Hmmm.... this is kind of a good point actually. @soranjh I think it is fine in qchem personally, but do you think this should be changed?

Yes, what @DSGuala suggested for creating a bose folder makes sense. We can add a proper qml_bose.rst file in doc/code, in a separate PR when the mapping PRs are merged.

pennylane/bose/__init__.py

DSGuala

Looks good to go! 💪

bosonic ops

a488e29

austingmhuang added 3 commits November 5, 2024 12:09

refactor

fe6a264

ordering fix

7ef89ff

small

57e55d0

austingmhuang requested a review from ddhawan11 November 5, 2024 22:54

ddhawan11 requested changes Nov 6, 2024

View reviewed changes

ddhawan11 and others added 3 commits November 7, 2024 07:44

Added christiansen boson and fixed the bug

844c04f

tests? could revert

180e26b

ascending order

59459a9

austingmhuang requested a review from soranjh November 7, 2024 22:16

austingmhuang and others added 6 commits November 8, 2024 09:26

Apply suggestions from code review

d5f82d3

Co-authored-by: Diksha Dhawan <40900030+ddhawan11@users.noreply.github.com>

Merge branch 'master' into bose_operators

67873a1

test fragments

06ae4ec

small fixes, and tests

07b8d96

[skip ci] black

d39a3d3

tests

c210ada

soranjh requested changes Nov 8, 2024

View reviewed changes

austingmhuang and others added 12 commits November 8, 2024 16:45

Update pennylane/labs/tests/vibrational_ham/test_bosonic.py

f33f120

Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>

Update pennylane/labs/vibrational_ham/bosonic.py

f0819be

Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>

Update pennylane/labs/vibrational_ham/bosonic.py

86fc4d6

Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>

Update pennylane/labs/vibrational_ham/bosonic.py

82a366a

Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>

Update pennylane/labs/vibrational_ham/bosonic.py

09f9981

Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>

Merge branch 'master' into bose_operators

6bc979d

Merge branch 'master' into bose_operators

18762b5

[skip ci] black

4beccf1

Merge branch 'master' into bose_operators

c493be4

change name to vibrational

718fe06

shift operator draft

4141d05

shift operator

fefa2cf

austingmhuang requested a review from soranjh November 20, 2024 23:27

ddhawan11 reviewed Nov 21, 2024

View reviewed changes

doc/releases/changelog-dev.md Outdated Show resolved Hide resolved

pennylane/qchem/vibrational/bosonic.py Outdated Show resolved Hide resolved

austingmhuang and others added 3 commits November 21, 2024 09:29

modify changelog

d5a2269

forgot period

99f9b51

Merge branch 'master' into bose_operators

2d4df8e

austingmhuang requested a review from ddhawan11 November 21, 2024 14:31

soranjh reviewed Nov 21, 2024

View reviewed changes

doc/releases/changelog-dev.md Outdated Show resolved Hide resolved

obliviateandsurrender approved these changes Nov 21, 2024

View reviewed changes

doc/releases/changelog-dev.md Outdated Show resolved Hide resolved

pennylane/qchem/vibrational/bosonic.py Outdated Show resolved Hide resolved

tests/qchem/vibrational_tests/test_bosonic.py Outdated Show resolved Hide resolved

austingmhuang and others added 2 commits November 21, 2024 10:58

Update doc/releases/changelog-dev.md

72b7973

Co-authored-by: Utkarsh <utkarshazad98@gmail.com>

fix

e79dc62

austingmhuang requested a review from soranjh November 21, 2024 16:05

ddhawan11 approved these changes Nov 21, 2024

View reviewed changes

soranjh approved these changes Nov 21, 2024

View reviewed changes

doc/releases/changelog-dev.md Outdated Show resolved Hide resolved

Update doc/releases/changelog-dev.md

21e8aec

Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>

austingmhuang added the merge-ready ✔️ All tests pass and the PR is ready to be merged. label Nov 21, 2024

Merge branch 'master' into bose_operators

c7af9a4

DSGuala reviewed Nov 21, 2024

View reviewed changes

tests/qchem/vibrational_tests/test_bosonic.py Outdated Show resolved Hide resolved

austingmhuang added 2 commits November 21, 2024 14:19

move to bose

0b0ae80

del blank line

d8fbb07

soranjh reviewed Nov 21, 2024

View reviewed changes

pennylane/bose/__init__.py Outdated Show resolved Hide resolved

austingmhuang added 2 commits November 21, 2024 14:26

fix

ba4eb9b

change qml.qchem to qml.bose

2028459

DSGuala approved these changes Nov 22, 2024

View reviewed changes

austingmhuang and others added 2 commits November 22, 2024 09:22

bs normal order example, imports

8ad2530

Merge branch 'master' into bose_operators

d87473e

austingmhuang enabled auto-merge (squash) November 22, 2024 14:23

austingmhuang merged commit 9c1292d into master Nov 22, 2024
45 checks passed

austingmhuang deleted the bose_operators branch November 22, 2024 14:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support the construction of bosonic operators #6518

Support the construction of bosonic operators #6518

austingmhuang commented Nov 5, 2024 •

edited

Loading

github-actions bot commented Nov 5, 2024

ddhawan11 left a comment

soranjh left a comment

obliviateandsurrender left a comment

ddhawan11 left a comment

DSGuala left a comment •

edited

Loading

austingmhuang commented Nov 21, 2024 •

edited

Loading

soranjh commented Nov 21, 2024 •

edited

Loading

DSGuala left a comment

Support the construction of bosonic operators #6518

Support the construction of bosonic operators #6518

Conversation

austingmhuang commented Nov 5, 2024 • edited Loading

github-actions bot commented Nov 5, 2024

ddhawan11 left a comment

Choose a reason for hiding this comment

soranjh left a comment

Choose a reason for hiding this comment

obliviateandsurrender left a comment

Choose a reason for hiding this comment

ddhawan11 left a comment

Choose a reason for hiding this comment

DSGuala left a comment • edited Loading

Choose a reason for hiding this comment

austingmhuang commented Nov 21, 2024 • edited Loading

soranjh commented Nov 21, 2024 • edited Loading

DSGuala left a comment

Choose a reason for hiding this comment

austingmhuang commented Nov 5, 2024 •

edited

Loading

DSGuala left a comment •

edited

Loading

austingmhuang commented Nov 21, 2024 •

edited

Loading

soranjh commented Nov 21, 2024 •

edited

Loading