angle solver qsp/qsvt #6483
Merged
angle solver qsp/qsvt #6483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6483 +/- ##
=======================================
Coverage 99.65% 99.65%
=======================================
Files 456 456
Lines 42993 43060 +67
=======================================
+ Hits 42844 42911 +67
Misses 149 149 ☔ View full report in Codecov by Sentry. |
…nylane into angle_solver_qsp
soranjh
added
the
do not merge ⚠️
JerryChen97
reviewed
Nov 12, 2024
JerryChen97
reviewed
Nov 12, 2024
Co-authored-by: Yushao Chen (Jerry) <chenys13@outlook.com>
KetpuntoG
commented
Nov 21, 2024
soranjh
requested changes
Nov 22, 2024
[skip ci] Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
Jaybsoni
approved these changes
Nov 28, 2024
Co-authored-by: Jay Soni <jbsoni@uwaterloo.ca>
soranjh
requested changes
Nov 29, 2024
[skip ci] Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
soranjh
requested changes
Nov 29, 2024
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
soranjh
approved these changes
Nov 29, 2024
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
JerryChen97
reviewed
Nov 29, 2024
Co-authored-by: Yushao Chen (Jerry) <chenys13@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
This PR appears in the context of the QSVT project, specifically focusing on the implementation of the angle solver, functionality to calculate the angles needed to apply a polynomial transformation.
Description of the Change:
Added
qml.poly_to_angles, the main functionality of the PR that takes as input a polynomial and returns the angles.Also included is the function
qml.transform_angles, which transforms the angle format between qsp and qsvt.Both these functions and other auxiliary functions have been added in
qsvt.py.Benefits:
Calculating angles is not a simple task and existing libraries have some limitations. With this new functionality we will facilitate the use of routines such as qsp and qsvt.
Possible Drawbacks:
Currently only one solver has been introduced. In the future it is expected to add more that will work for more extreme cases: larger polynomials (degree > 1000) or degenerate polynomials
[sc-72631]