-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding documentation on device docs #6325
base: master
Are you sure you want to change the base?
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6325 +/- ##
=======================================
Coverage 99.39% 99.39%
=======================================
Files 448 448
Lines 42472 42474 +2
=======================================
+ Hits 42217 42219 +2
Misses 255 255 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel that in many cases, this guide is explaining different aspects of the execution workflow without putting it in the context of how a plugin can be implemented. Many examples describes how a device should behave and how it is used in the workflow but there isn't a corresponding example to explain what a plugin developer needs to do to make it work like expected.
Co-authored-by: Astral Cai <astral.cai@xanadu.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for doing this! 🎸
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Christina! Looks good to me, just found some grammar suggestions.
Co-authored-by: Isaac De Vlugt <34751083+isaacdevlugt@users.noreply.github.com>
Co-authored-by: Isaac De Vlugt <34751083+isaacdevlugt@users.noreply.github.com>
Co-authored-by: Isaac De Vlugt <34751083+isaacdevlugt@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if these are related to the failing doc builds.
Co-authored-by: Astral Cai <astral.cai@xanadu.ai>
Context:
Replacing stale #5783 [sc-53730]
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues: