-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change wire repr #5958
Change wire repr #5958
Conversation
[sc-67920] |
Tagging @isaacdevlugt for visibility - not sure if this PR is ready to take a look at yet. |
It's ready! It's a very small PR that just addresses the changes that come about with changing the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5958 +/- ##
==========================================
- Coverage 99.67% 99.67% -0.01%
==========================================
Files 425 425
Lines 40926 40630 -296
==========================================
- Hits 40793 40496 -297
- Misses 133 134 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Context:
To accommodate the implementation of
qml.registers
, the_repr_
of Wires should be something more copy-paste friendly rather than what it is currentlyDescription of the Change:
The
_repr_
of Wires is nowWires([0])
rather than<Wires = [0]>
Benefits:
Easier to copy and paste
Possible Drawbacks:
Might make docs confusing in other places. Not sure where else <Wires = ...> notation will be found in docs.
Related GitHub Issues: