-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing Exact Tensor Network method for default.tensor
#5786
Conversation
tns
method to default.tensor
tns
method to default.tensor
tns
method for default.tensor
tns
method for default.tensor
default.tensor
…o tn_method_default_tensor
Thanks @vincentmr, I am in total favor of adding rehearsals for the TN method in another PR. This argument can be passed indeed to the local_expectation function |
Thank you @Qottmann.
I agree. I tried to separate the two in the
Good point, I think that would be very helpful, but probably in a separate tutorial or a slightly different context. Here I think we already provided a lot of information compared to the docs of other devices |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work landing all TN features @PietropaoloFrisoni . I think this is ready to merge. I'm leaving suggestions but nothing blocking on my side.
…o tn_method_default_tensor
@vincentmr Thanks, excellent suggestions! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, great work @PietropaoloFrisoni !
The docs could still be a bit more beginner friendly for a lay person but that should not block this PR 👍
Context: Currently, the new
default.tensor
device can only simulate quantum circuits using the Matrix Product State (MPS) method, based onquimb
'sCircuitMPS
class.Description of the Change: With this PR, the device also supports the Exact Tensor Network method based on
quimb
'sCircuit
class. This completes the implementation of themethod
keyword argument, which can be set to eithermps
ortn
. For this quarter, this is expected to be the last feature for thedefault.tensor
device (except for refinements, bug fixes, and performance improvements).Benefits: A new simulation method is implemented for this device, enabling new functionalities for users.
Possible Drawbacks: This PR just implements an additional method, but it does not modify the existing functionalities (except for some minor improvements and clarifications in the documentation).
Related GitHub Issues: None.
Related Shortcut Stories:
[sc-60805]
[sc-64011]
[sc-64284]