-
Notifications
You must be signed in to change notification settings - Fork 644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix output dimensions bug in hamiltonian_expand #5494
Conversation
…lse" Yeah it did break something else This reverts commit a24b59a.
…o ham-expand-dim
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5494 +/- ##
==========================================
- Coverage 99.67% 99.66% -0.01%
==========================================
Files 406 406
Lines 37881 37622 -259
==========================================
- Hits 37758 37497 -261
- Misses 123 125 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only real comment is that I'd like it if the tests checked the result, not only the result shape, since that doesn't really seem to be covered anywhere for the broadcasting branch of the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good to me @astralcai!
Context:
hamiltonian_expand
reverses the order of dimensions for shot vectors and parameter broadcastingDescription of the Change:
Change a transpose operation to only transpose the last two dimensions if applicable.
Related GitHub Issues:
Fixes #5493
[sc-61037]