Add algorithmic errors tracking to qml.specs
#5464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[sc-55444] |
obliviateandsurrender
changed the title
qml.specsqml.specs
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5464 +/- ##
==========================================
- Coverage 99.67% 99.66% -0.01%
==========================================
Files 404 404
Lines 37833 37554 -279
==========================================
- Hits 37709 37429 -280
- Misses 124 125 +1 ☔ View full report in Codecov by Sentry. |
soranjh
requested changes
Apr 11, 2024
There was a problem hiding this comment.
Thanks @obliviateandsurrender, looks good already, left some small comments and suggestions.
Jaybsoni
reviewed
Apr 11, 2024
soranjh
reviewed
Apr 11, 2024
soranjh
approved these changes
Apr 12, 2024
Jaybsoni
approved these changes
Apr 12, 2024
trbromley
reviewed
Apr 15, 2024
There was a problem hiding this comment.
Thanks @obliviateandsurrender @Jaybsoni! Looks great. Just want to CC @DSGuala to make sure he's in the loop.
| gate_sizes=defaultdict(<class 'int'>, {1: 1, 2: 1}), depth=2, shots=Shots(total_shots=None, shot_vector=())), | ||
| {'resources': Resources(num_wires=2, num_gates=4, gate_types=defaultdict(<class 'int'>, {'RX': 1, 'CNOT': 1, 'TrotterPro | ||
| duct': 2}}), gate_sizes=defaultdict(<class 'int'>, {1: 3, 2: 1}), depth=4, shots=Shots(total_shots=None, shot_vector=())), | ||
| 'errors': {'SpectralNormError': SpectralNormError(0.42998560822421455)}, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: Update
qml.specsto track and combine errorDescription of the Change: Adds a
_compute_algo_errormethod that combines the individual errors of similar types. Further updatesspecsmethod ofQuantumScriptto use the prior method for the required computation in a similar fashion toresources.Benefits:
specswill track algorithmic errors.Possible Drawbacks: N/A
Related GitHub Issues: N/A