-
Notifications
You must be signed in to change notification settings - Fork 644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate qml.from_qasm_file #5331
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @astralcai!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5331 +/- ##
==========================================
- Coverage 99.64% 99.63% -0.01%
==========================================
Files 401 401
Lines 37294 36975 -319
==========================================
- Hits 37160 36840 -320
- Misses 134 135 +1 ☔ View full report in Codecov by Sentry. |
Thanks @astralcai! Note that this led to another failure in the plugin tests: https://github.com/PennyLaneAI/plugin-test-matrix/actions/runs/8241505756/job/22538896791#step:8:626 |
Context:
qml.from_qasm_file
is an additional function to maintain that does not add much to the already existingqml.from_qasm
. It is being deprecated, and users are directed to open the file themselves and load its content usingqml.from_qasm
.Description of the Change:
Deprecation warning added to
qml.from_qasm_file
Example code added to
qml.from_qasm
that reads a qasm file and loads withqml.from_qasm
Related Shortcut Issues:
[sc-56057]