Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MeasurementProcess.name and MeasurementProcess.data #5321

Merged
merged 9 commits into from
Mar 7, 2024
Merged

Conversation

astralcai
Copy link
Contributor

Context:
Completing the deprecation cycle of MeasurementProcess.name and MeasurementProcess.data

Description of the Change:
Removes MeasurementProcess.name and MeasurementProcess.data

Related Shortcut Story
[sc-58122]

@astralcai astralcai marked this pull request as ready for review March 6, 2024 16:09
@astralcai astralcai requested a review from a team March 6, 2024 16:10
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.63%. Comparing base (79d3990) to head (8ed59c1).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5321      +/-   ##
==========================================
- Coverage   99.64%   99.63%   -0.01%     
==========================================
  Files         401      400       -1     
  Lines       37115    36819     -296     
==========================================
- Hits        36983    36685     -298     
- Misses        132      134       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@astralcai astralcai requested a review from a team March 7, 2024 14:33
@albi3ro
Copy link
Contributor

albi3ro commented Mar 7, 2024

=========================== short test summary info ============================
FAILED tests/interfaces/test_tensorflow_qnode_shot_vector.py::TestReturnShotVectorIntegration::test_single_expectation_value[tf-default.qubit.legacy-spsa-gradient_kwargs2-shots0-3] - assert False
 +  where False = <function primitive.<locals>.f_wrapped at 0x7f931a71f280>(<tf.Tensor: shape=(3,), dtype=float64, numpy=array([0.851709  , 0.85403056, 0.85048312])>, tensor(0.31434676, dtype=float32, requires_grad=True), atol=0.5, rtol=0)
 +    where <function primitive.<locals>.f_wrapped at 0x7f931a71f280> = np.allclose
= 1 failed, 2676 passed, 106 skipped, 10 xfailed, 53 warnings in 402.29s (0:06:42) =
Error: Process completed with exit code 1.

More rng issues?

@astralcai
Copy link
Contributor Author

=========================== short test summary info ============================
FAILED tests/interfaces/test_tensorflow_qnode_shot_vector.py::TestReturnShotVectorIntegration::test_single_expectation_value[tf-default.qubit.legacy-spsa-gradient_kwargs2-shots0-3] - assert False
 +  where False = <function primitive.<locals>.f_wrapped at 0x7f931a71f280>(<tf.Tensor: shape=(3,), dtype=float64, numpy=array([0.851709  , 0.85403056, 0.85048312])>, tensor(0.31434676, dtype=float32, requires_grad=True), atol=0.5, rtol=0)
 +    where <function primitive.<locals>.f_wrapped at 0x7f931a71f280> = np.allclose
= 1 failed, 2676 passed, 106 skipped, 10 xfailed, 53 warnings in 402.29s (0:06:42) =
Error: Process completed with exit code 1.

More rng issues?

Seems like it.

@astralcai astralcai enabled auto-merge (squash) March 7, 2024 18:16
@astralcai astralcai merged commit c12a29c into master Mar 7, 2024
40 checks passed
@astralcai astralcai deleted the dep-mp branch March 7, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants