-
Notifications
You must be signed in to change notification settings - Fork 644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend the device test suite: gradient, op-arithmetic and template tests #5273
Conversation
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5273 +/- ##
==========================================
- Coverage 99.67% 99.66% -0.01%
==========================================
Files 404 404
Lines 37833 37554 -279
==========================================
- Hits 37709 37429 -280
- Misses 124 125 +1 ☔ View full report in Codecov by Sentry. |
c4c6ca5
to
511b7af
Compare
# Conflicts: # doc/releases/changelog-dev.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a few small comments there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good! 🎸
# Conflicts: # pennylane/devices/tests/test_measurements.py
this change will require branch protection updates because of |
Co-authored-by: Christina Lee <christina@xanadu.ai>
I ran the plugin test suite against this branch so I could see which tests fail right away on which devices (done, see here, braket and quantuminspire are failing for their own reasons), and skip them for those devices. Everything is now passing as expected.
Context:
The device test suite doesn't cover a lot of PennyLane's features, so I'm adding more coverage.
Description of the Change:
default.qubit.autograd
)test_measurements.py
to test some basic arithmetic ops by comparing the result todefault.qubit
test_basic_grad
,test_backprop_state
,test_parameter_shift
,test_probs
,test_multi_meas
test_hessian
. They do what they sound like they do 😄qml.state()
withqml.probs()
whenever possible so the test would work with finite-shot devices.Benefits:
More confidence in our plugin devices!
Possible Drawbacks:
[sc-57488]