[Terms1] Add Prod.terms() method
#5132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
|
[sc-55894] |
…into prodterms
6 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5132 +/- ##
==========================================
- Coverage 99.69% 99.68% -0.01%
==========================================
Files 394 394
Lines 36118 35860 -258
==========================================
- Hits 36007 35748 -259
- Misses 111 112 +1 ☔ View full report in Codecov by Sentry. |
5 tasks
mudit2812
reviewed
Feb 5, 2024
mudit2812
approved these changes
Feb 6, 2024
Qottmann
requested review from
trbromley and
albi3ro
and removed request for
albi3ro
albi3ro
approved these changes
Feb 6, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5132 +/- ##
==========================================
- Coverage 99.68% 99.67% -0.01%
==========================================
Files 394 394
Lines 36298 36040 -258
==========================================
- Hits 36183 35924 -259
- Misses 115 116 +1 ☔ View full report in Codecov by Sentry. |
|
Are there similar performance questions here as in #5133? |
Yep same same |
albi3ro
added a commit
that referenced
this pull request
Feb 9, 2024
Builds on top of #5132 and adds a meaningul `Sum.terms()` method that returns a tuple of coefficients and ops to be at feature parity with `qml.Hamiltonian` - [x] Basic functionality - [x] Tests with Paulis - [x] Tests without Paulis - [x] Docs - [x] changelog - [x] handle empty pauli words --------- Co-authored-by: albi3ro <chrissie.c.l@gmail.com> Co-authored-by: Christina Lee <christina@xanadu.ai> Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
Qottmann
added a commit
that referenced
this pull request
Feb 22, 2024
…5164) Following #5132 and #5133, the overarching goal is to achieve feature parity with `qml.Hamiltonian`, which on the other hand is part of the overarching goal of activating new opmath by default. While for `qml.Hamiltonian` it made sense to access `coeffs` and `ops` directly, in `Sum` and `Prod` it requires some processing so it makes more sense (and costs less) to directly call the `terms()` method to obtain both. [sc-56284] [sc-53963] --------- Co-authored-by: albi3ro <chrissie.c.l@gmail.com> Co-authored-by: Christina Lee <christina@xanadu.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The overall goal is to have
Sum.terms()give meaningful results. This is necessary to achieve feature parity withqml.Hamiltonianto be able to soon switch to new opmath be the default. We realized that a necessity forSum.terms()to work properly we also need aProd.terms()method that is compatible with that.In particular with this PR you can do:
You can think of it like this: When the operator has a
pauli_repits just taking all values as coeffs and all keys as operators. This PR additionally handles all cases where no pauli rep is available. In essence, it is doing the same steps assimplifymodulo some small differences (like not discerning cases of just one single term as that still yields[factor], [op]).