-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add min version for Catalyst to qml.compiler
#4979
Conversation
Updates PennyLane as we're entering a new development version (release of v0.34.0 coming up): - Create changelog-dev.md - Add changelog-dev.md to release-notes.md - Increments the version number to v0.35.0-dev - Update rc_sync.yml to replace the previous release manager It **must not be merged** before the creation of the release candidate branch 0.34.0 ``` rc master | | | - (**THIS PR**) changelog and version updates for 0.35.0-dev | / | / | / | / |/ - changelog and version updates for 0.34.0 RC branch | | ```
Hello. You may have forgotten to update the changelog!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
made some suggestions to use semantic-version
to avoid adding another dependency to PennyLane (not sure if I got the syntax exactly right, but I think it should do)
05a799b
to
7a62897
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @maliasadi! 🚀
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v0.34.0-rc0 #4979 +/- ##
==============================================
Coverage ? 99.66%
==============================================
Files ? 392
Lines ? 35285
Branches ? 0
==============================================
Hits ? 35168
Misses ? 117
Partials ? 0 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @maliasadi :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great 🙂
|
||
if name == "catalyst": | ||
installed_catalyst_version = metadata.version("pennylane-catalyst") | ||
print(installed_catalyst_version) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🦖
The new PL version should check that the Catalyst version, if installed, is at least
v0.4.0
.Note there are a couple of TODOs to address after releasing Catalyst
v0.4.0
.[sc-52634]