Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Classical conditions in the matplotlib drawer #4850

Merged
merged 79 commits into from
Dec 7, 2023
Merged

Classical conditions in the matplotlib drawer #4850

merged 79 commits into from
Dec 7, 2023

Conversation

albi3ro
Copy link
Contributor

@albi3ro albi3ro commented Nov 16, 2023 •
edited
Loading

This PR depends on #4832 and #4803

midmeasure_mpl

[sc-48302]

mudit2812 and others added 30 commits November 2, 2023 10:20
@mudit2812
Testing different labels
3e2e888
@mudit2812
Linting
875c21e
@mudit2812
Update doc/releases/changelog-dev.md
0322db1
@mudit2812
Updated label
eda9d87
@mudit2812
Added tests
6097994
@mudit2812
Merge branch 'master' into draw-mcm-1
207f697
@mudit2812
[skip ci] why wont it work
c4255e6
@mudit2812
Added test with larger circuit
95d3d33
@mudit2812
Get drawing to work
3dab584
@mudit2812
[skip ci] Addressing review; removing old artifacts
63e4106
@albi3ro
tmp
591bb8a
@mudit2812
Updated indexing
35a3728
@mudit2812
Merge branch 'master' into draw-mcm-2
59b42fe
@mudit2812
Linting
23ee838
@mudit2812
[skip ci] Always left align
f4d6d2e
@mudit2812
[skip ci] Adding stuff as foundation for future work
515aba2
@mudit2812
[skip ci] Linting
2bdc9ec
@albi3ro
exploring mid circuit measurements with mpl
6c6784d
@mudit2812
[skip ci] Reverted debugging related changes
af3c465
@mudit2812
Merge branch 'master' into draw-mcm-2
7680403
@mudit2812
Fixed non-mcm drawing error
5ca9371
@mudit2812
Merge branch 'master' into draw-mcm-2
e290341
@mudit2812
Fixed drawer tests
4cddf70
@mudit2812
pull
e6e4c03
@mudit2812
Refactoring
e77c8f2
@albi3ro
draw_mpl shows qubit reuse and reset
6bc678e
@albi3ro
Merge branch 'master' into mpl-midmeasure
9a1e9f6
@albi3ro
tweak measure numbers
3d2b301
@albi3ro
add testing
77caad6
@albi3ro
oops
4261333
@mudit2812 mudit2812 mentioned this pull request Nov 30, 2023
Merged
@albi3ro albi3ro marked this pull request as ready for review December 5, 2023 19:55
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2023

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@albi3ro albi3ro changed the base branch from master to cwire-connections December 5, 2023 20:10
albi3ro
albi3ro commented Dec 6, 2023
View reviewed changes
@KetpuntoG KetpuntoG mentioned this pull request Dec 6, 2023
Closed
3 tasks
Base automatically changed from cwire-connections to master December 6, 2023 21:55
albi3ro
albi3ro commented Dec 6, 2023
View reviewed changes
@albi3ro albi3ro requested review from mudit2812 and a team December 6, 2023 23:05
timmysilv
timmysilv approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@timmysilv timmysilv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some non-blocking concerns

mudit2812
mudit2812 approved these changes Dec 7, 2023
View reviewed changes
@albi3ro @mudit2812
Apply suggestions from code review
26b333e 
Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
@codecov Codecov
Copy link

codecov bot commented Dec 7, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e2dfd64) 99.66% compared to head (cd9dfd7) 99.66%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4850      +/-   ##
==========================================
- Coverage   99.66%   99.66%   -0.01%     
==========================================
  Files         387      387              
  Lines       35049    34812     -237     
==========================================
- Hits        34932    34694     -238     
- Misses        117      118       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albi3ro albi3ro enabled auto-merge (squash) December 7, 2023 21:18
@albi3ro albi3ro merged commit 49b0b71 into master Dec 7, 2023
@albi3ro albi3ro deleted the mpl-cond branch December 7, 2023 22:01
mudit2812 added a commit that referenced this pull request Jan 19, 2024
@albi3ro @mudit2812
Classical conditions in the matplotlib drawer (#4850)
9d71b73 
This PR depends on #4832 and #4803 



![midmeasure_mpl](https://github.com/PennyLaneAI/pennylane/assets/6364575/06147924-684d-4bd5-a8aa-5a266bf19852)

[sc-48302]

---------

Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timmysilv timmysilv timmysilv approved these changes

@mudit2812 mudit2812 mudit2812 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@albi3ro @mudit2812 @timmysilv