[BUGFIX] Qubit reuse for terminal measurements on wires with mid-circuit measurements #4787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4787 +/- ##
==========================================
- Coverage 99.64% 99.63% -0.02%
==========================================
Files 381 381
Lines 34302 34048 -254
==========================================
- Hits 34181 33924 -257
- Misses 121 124 +3
☔ View full report in Codecov by Sentry. |
mudit2812
requested review from
timmysilv and
lillian542
and removed request for
a team
timmysilv
pushed a commit
that referenced
this pull request
Nov 8, 2023
…uit measurements (#4787) **Context:** When making terminal measurements on wires with mid-circuit measurements, the circuit was not being transformed correctly. This PR fixes that. **Description of the Change:** Wires are considered to be reused by `defer_measurements` when a measured wire has operators *and* terminal measurements applied to it after mid-circuit measurements. **Benefits:** **Possible Drawbacks:** **Related GitHub Issues:** [sc-49507]
timmysilv
added a commit
that referenced
this pull request
Nov 8, 2023
**Context:** These three bugs were identified as good to be released in a bugfix. **Description of the Change:** Cherry-pick the 3 commits to master onto this branch for the 0.33.1 bugfix release **Benefits:** Fixed bugs pushed out! **Possible Drawbacks:** Extra work in a critical time. **Related GitHub Issues:** #4768, #4781, #4787 --------- Co-authored-by: Christina Lee <christina@xanadu.ai> Co-authored-by: lillian542 <38584660+lillian542@users.noreply.github.com> Co-authored-by: Tom Bromley <49409390+trbromley@users.noreply.github.com> Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
When making terminal measurements on wires with mid-circuit measurements, the circuit was not being transformed correctly. This PR fixes that.
Description of the Change:
Wires are considered to be reused by
defer_measurementswhen a measured wire has operators and terminal measurements applied to it after mid-circuit measurements.Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-49507]