Support drawing MidMeasureMP with qml.draw
#4775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mudit2812
commented
Nov 2, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4775 +/- ##
==========================================
- Coverage 99.64% 99.63% -0.01%
==========================================
Files 381 381
Lines 34324 34074 -250
==========================================
- Hits 34202 33951 -251
- Misses 122 123 +1
☔ View full report in Codecov by Sentry. |
timmysilv
reviewed
Nov 6, 2023
trbromley
reviewed
Nov 6, 2023
|
@mudit2812 please could you link the SC story |
timmysilv
approved these changes
Nov 8, 2023
|
[sc-49111] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Mid-circuit measurements cannot be drawn with
qml.draw. This is the first PR to support drawing mid-circuit measurementsDescription of the Change:
MidMeasureMP, including cases of qubit reset and postselection.qml.drawer.tape_textto support drawing measurements in the ops queue. Measurements without a definedlabelmethod (which is all measurements except MidMeasureMP`) will still break the drawer, which is what we want.Benefits:
We can now draw mid-circuit measurements!
qml.condis still not supported. That will come in future PRsPossible Drawbacks:
Related GitHub Issues: