New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Compiler] Add Catalyst ctrl #4726

Merged

rmoyard merged 41 commits into master from catalyst_ctrl

Nov 29, 2023

Contributor

rmoyard commented Oct 24, 2023 •

edited

Loading

Description of the Change:

This PR adds support for QJIT compatible qml.ctrl.

maliasadi and others added 18 commits

October 17, 2023 22:01


          Add the compiler module

3b192cc


          Add pl/compiler.py

bb171d6


          Add python tests

621ad52


          Update tests

8288b5a


          Add docstring

b421a77


          Update compiler tests

d2e12e2


          Remove the Compiler static class in favor of using the compiler modul…

1de0a92

…e. Add the AvailableCompilers dataclass and update tests


          Use pytest.mark.external for catalyst and jax in tests

d84fab0


          Add the compiler module to docs

4fc9672


          Update docstring


          Update docstring

c58d210


          Apply suggestions from code review

31fe693

Co-authored-by: Josh Izaac <josh146@gmail.com>


          Update docstrings and args

2cc2e97


          Update adding the compiler section

04de229


          Use defaultdict

c6732a5


          Compiler documentation (#4702)

86f2baf

**Context:** Catalyst frontend is being integrated into PL

**Description of the Change:** Attempt to add Catalyst to intersphinx to
help with cross referencing of docs

**Benefits:**

**Possible Drawbacks:**

[sc-46399]

---------

Co-authored-by: Ali Asadi <ali@xanadu.ai>


          Merge branch 'master' into maa/integrate-catalyst-2

f98730a


          Draft

5efb584

Contributor

github-actions bot commented Oct 24, 2023

Hello. You may have forgotten to update the changelog!
Please edit doc/releases/changelog-dev.md with:

A one-to-two sentence description of the change. You may include a small working example for new features.
A link back to this PR.
Your name (or GitHub username) in the contributors section.

rmoyard changed the title ~~[Compiler] Catalyst ctrl~~ [Compiler] Add Catalyst ctrl

codecov bot commented Oct 24, 2023 •

edited

Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (35a34e6) 99.65% compared to head (c63ea7d) 99.64%.
Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4726      +/-   ##
==========================================
- Coverage   99.65%   99.64%   -0.02%     
==========================================
  Files         387      387              
  Lines       34960    34703     -257     
==========================================
- Hits        34840    34580     -260     
- Misses        120      123       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

maliasadi and others added 2 commits

October 25, 2023 13:10


          Update docstrings; Add CompileError

72e5f3f


          Update pennylane/compiler/__init__.py

02b07ab

Co-authored-by: David Ittah <dime10@users.noreply.github.com>

Contributor Author

rmoyard commented Oct 25, 2023

maliasadi added 2 commits

October 25, 2023 15:01


          Add compiler.active_compiler

9224e9b


          Update docstrings

9c593fe

maliasadi added the compiler 🏭 label

maliasadi and others added 3 commits

October 25, 2023 16:52


          Apply suggestions from code review

e69c1a4

Co-authored-by: Josh Izaac <josh146@gmail.com>


          Add Optional[str]

47187e6


          Add test

68c3e31

maliasadi requested review from josh146 and dime10

October 27, 2023 16:32

rmoyard and others added 5 commits

October 27, 2023 13:38


          Update pennylane/ops/op_math/controlled.py

7eb7edc

Co-authored-by: Ali Asadi <ali@xanadu.ai>


          Update tests/test_compiler.py

71e88fb

Co-authored-by: Ali Asadi <ali@xanadu.ai>


          Update tests/test_compiler.py

80ece52

Co-authored-by: Ali Asadi <ali@xanadu.ai>


          Update from review


          Merge branch 'maa/integrate-catalyst-2' into catalyst_ctrl

1b073f9

rmoyard requested a review from maliasadi

October 27, 2023 17:46

maliasadi reviewed

View reviewed changes

pennylane/ops/op_math/controlled.py Outdated Show resolved Hide resolved

tests/test_compiler.py Outdated Show resolved Hide resolved

rmoyard and others added 2 commits

October 27, 2023 14:36


          Update tests/test_compiler.py

fce62ba

Co-authored-by: Ali Asadi <ali@xanadu.ai>


          Update pennylane/ops/op_math/controlled.py

480d311

Co-authored-by: Ali Asadi <ali@xanadu.ai>

maliasadi reviewed

View reviewed changes

pennylane/ops/op_math/controlled.py Show resolved Hide resolved

josh146 approved these changes

View reviewed changes

Member

josh146 left a comment

Nice @rmoyard! Just one fix in the docstring but otherwise looking good.

pennylane/ops/op_math/controlled.py Outdated Show resolved Hide resolved


          Apply suggestions from code review

cdc5a9a

Co-authored-by: Josh Izaac <josh146@gmail.com>
Co-authored-by: Ali Asadi <ali@xanadu.ai>

timmysilv reviewed

View reviewed changes

pennylane/ops/op_math/controlled.py Outdated Show resolved Hide resolved

pennylane/ops/op_math/controlled.py Show resolved Hide resolved

tests/test_compiler.py Show resolved Hide resolved


          Apply suggestions from code review

7f35ff1

Co-authored-by: Matthew Silverman <matthews@xanadu.ai>

Base automatically changed from maa/integrate-catalyst-2 to master

November 28, 2023 17:25


          Merge branch 'master' into catalyst_ctrl

396ea48

timmysilv approved these changes

View reviewed changes

rmoyard added 2 commits

November 29, 2023 11:20


          Merge branch 'master' into catalyst_ctrl

add6230


          Changelog

9f6c63e

rmoyard enabled auto-merge (squash)

November 29, 2023 16:23

rmoyard added 2 commits

November 29, 2023 11:45


          Trigger CI

59659bf


          Merge branch 'master' into catalyst_ctrl

629888f

rmoyard requested a review from maliasadi

November 29, 2023 17:43

maliasadi approved these changes

View reviewed changes

doc/releases/changelog-dev.md Outdated Show resolved Hide resolved

pennylane/ops/op_math/controlled.py Outdated Show resolved Hide resolved

maliasadi added 2 commits

November 29, 2023 14:42


          Apply suggestions from code review

b5e8ba0


          Update pennylane/ops/op_math/controlled.py

c63ea7d

rmoyard merged commit c7cda37 into master

rmoyard deleted the catalyst_ctrl branch

November 29, 2023 19:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels