Downstream LightningSimulator C++ API to the pennylane-lightning repository #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlxd
reviewed
Oct 28, 2024
pennylane_lightning/core/src/simulators/lightning_qubit/catalyst/LightningSimulator.cpp
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #960 +/- ##
==========================================
- Coverage 97.97% 91.76% -6.21%
==========================================
Files 221 179 -42
Lines 33726 24889 -8837
==========================================
- Hits 33043 22840 -10203
- Misses 683 2049 +1366 ☔ View full report in Codecov by Sentry. |
rauletorresc
force-pushed
the
raultorres/catalyst_LQ
branch
from
4c54c9f to
497f0e3
Compare
rauletorresc
force-pushed
the
raultorres/catalyst_LQ
branch
4 times, most recently
from
3e05dbf to
00bf076
Compare
This reverts commit 80714a6.
paul0403
reviewed
Nov 6, 2024
pennylane_lightning/core/src/simulators/lightning_qubit/catalyst/LightningSimulator.cpp
Show resolved
Hide resolved
paul0403
reviewed
Nov 6, 2024
pennylane_lightning/core/src/simulators/lightning_qubit/catalyst/LightningSimulator.cpp
Show resolved
Hide resolved
maliasadi
added
ci:build_wheels
maliasadi
reviewed
Nov 12, 2024
There was a problem hiding this comment.
Thanks @rauletorresc! I'm concerned about the new dependencies on runtime/capi and runtime/tests. Let's resolve the remaining comments before merging the PR :)
maliasadi
approved these changes
Nov 12, 2024
multiphaseCFD
approved these changes
Nov 12, 2024
rauletorresc
added a commit
to PennyLaneAI/catalyst
that referenced
this pull request
Nov 15, 2024
**Context:** Catalyst needs to build a class wrapping the Lightning Qubit class. Here we are moving the logic from Catalyst to the Lightning repository. **Description of the Change:** Moving code from Catalyst to this repository and updating the build system to build against Catalyst. **Benefits:** Catalyst wheels will build faster. **Note:** We need the PR in lightning to be merged first PennyLaneAI/pennylane-lightning#960 [sc-70319] [sc-70317]
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: Catalyst needs to build a class wrapping the Lightning Qubit class. Here we are moving the logic from Catalyst to the Lightning repository.
Description of the Change: Moving code from Catalyst to this repository and updating the build system to build against Catalyst.
Benefits: Catalyst wheels will build faster.
Possible Drawbacks: Our build system now relies on headers coming from Catalyst. It is unclear if this may cause a deadlock in the future because of our cyclic dependencies (PennyLane, PennyLane Lightning, Catalyst). Chances are small because we don't rely on Catalyst wheels or build it from scratch.
[sc-70316]
[sc-70318]
[sc-70317]