Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Py3.9 to 3.10 minimum #891

Merged
merged 10 commits into from
Sep 6, 2024
Merged

Update Py3.9 to 3.10 minimum #891

merged 10 commits into from
Sep 6, 2024

Conversation

mlxd
Copy link
Member

@mlxd mlxd commented Sep 5, 2024

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context: This PR removes support for Python 3.9 and migrates to 3.10 as the oldest supported version.

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

Copy link
Contributor

github-actions bot commented Sep 5, 2024

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

@mlxd mlxd marked this pull request as ready for review September 5, 2024 18:40
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.15%. Comparing base (8c05022) to head (250cb3a).
Report is 80 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #891      +/-   ##
==========================================
+ Coverage   90.56%   97.15%   +6.58%     
==========================================
  Files          89      208     +119     
  Lines       11583    28228   +16645     
==========================================
+ Hits        10490    27424   +16934     
+ Misses       1093      804     -289     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super cool! Happy to approve!

@mlxd mlxd requested a review from maliasadi September 6, 2024 12:51
@mlxd
Copy link
Member Author

mlxd commented Sep 6, 2024

Just a note, PennyLaneAI/pennylane#6223 will merge before this, and PennyLaneAI/catalyst#1104 after this PR.

mlxd added a commit to PennyLaneAI/catalyst that referenced this pull request Sep 6, 2024
**Context:** This PR removes support for Python 3.9 and migrates to 3.10
as the oldest supported version.

**Description of the Change:**

**Benefits:** 

**Possible Drawbacks:**

**Related GitHub Issues:**
PennyLaneAI/pennylane-lightning#891
PennyLaneAI/pennylane#6223
@mlxd mlxd added the urgent Mark a pull request as high priority label Sep 6, 2024
@mlxd mlxd merged commit db98cbc into master Sep 6, 2024
130 checks passed
@mlxd mlxd deleted the dep/remove_py_39 branch September 6, 2024 22:16
multiphaseCFD pushed a commit that referenced this pull request Sep 8, 2024
### Before submitting

Please complete the following checklist when submitting a PR:

- [x] All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to
the
      [`tests`](../tests) directory!

- [x] All new functions and code must be clearly commented and
documented.
If you do make documentation changes, make sure that the docs build and
      render correctly by running `make docs`.

- [x] Ensure that the test suite passes, by running `make test`.

- [x] Add a new entry to the `.github/CHANGELOG.md` file, summarizing
the
      change, and including a link back to the PR.

- [x] Ensure that code is properly formatted by running `make format`. 

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


------------------------------------------------------------------------------------------------------------

**Context:** This PR removes support for Python 3.9 and migrates to 3.10
as the oldest supported version.

**Description of the Change:**

**Benefits:**

**Possible Drawbacks:**

**Related GitHub Issues:**

---------

Co-authored-by: ringo-but-quantum <github-ringo-but-quantum@xanadu.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:build_wheels Activate wheel building. urgent Mark a pull request as high priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants