-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix native mcm workflow following dynamic_one_shot refactor. #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## pw-reorder #694 +/- ##
==============================================
+ Coverage 95.49% 98.67% +3.17%
==============================================
Files 174 174
Lines 22616 22629 +13
==============================================
+ Hits 21598 22330 +732
+ Misses 1018 299 -719 ☔ View full report in Codecov by Sentry. |
maliasadi
reviewed
Apr 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vincentmr! 🦅
maliasadi
approved these changes
Apr 24, 2024
maliasadi
added a commit
that referenced
this pull request
Apr 24, 2024
* port PR changes so far, after traumatic rebase * update vjp tests * format * update vjp tests * update dev version * format * add tests for vjp * Auto update version * Auto update version * Updated tests * Updated serialization * Unpinned cmake * Update changelog * Update .github/CHANGELOG.md * isort * black * Run CI with updated PL branch * Auto update version * trigger ci * Added changes per review * Auto update version * Update requirements-dev.txt * Update pennylane_lightning/core/_serialize.py Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com> * Auto update version * Trigger CI * Update overlapping wires prod serialization test * Updated tests to work with new pauli word order * Added device_vjp tests * Update serialize tests * Auto update version * Skipped tf test * Auto update version * Auto update version * Trigger CI * Updated torch test * Update serialization tests; removed xfail * Trigger CI * Auto update version * Remove vjp tests * Trigger CI * Trigger CI * [skip ci] Revert requirements file * Auto update version from '0.36.0-dev35' to '0.36.0-dev36' * Trigger CI * Trigger CI * Fix native mcm workflow following dynamic_one_shot refactor. (#694) * Fix native mcm workflow following dynamic_one_shot refactor. * Auto update version from '0.36.0-dev35' to '0.36.0-dev36' * Update changelog. --------- Co-authored-by: ringo-but-quantum <github-ringo-but-quantum@xanadu.ai> --------- Co-authored-by: AmintorDusko <amintor_dusko@hotmail.com> Co-authored-by: Amintor Dusko <87949283+AmintorDusko@users.noreply.github.com> Co-authored-by: Vincent Michaud-Rioux <vincent.michaud-rioux@xanadu.ai> Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com> Co-authored-by: ringo-but-quantum <github-ringo-but-quantum@xanadu.ai> Co-authored-by: Vincent Michaud-Rioux <vincentm@nanoacademic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests
directory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
.github/CHANGELOG.md
file, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-61844]