Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the failed observable serialization unit tests #683

Merged
merged 8 commits into from
Apr 17, 2024

Conversation

maliasadi
Copy link
Member

PR PennyLaneAI/pennylane#5475 led to LQ and LK serialization unit tests failures. This PR updates them to pass on CIs.

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.99%. Comparing base (d0e1c51) to head (44135a0).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #683      +/-   ##
==========================================
- Coverage   99.37%   97.99%   -1.38%     
==========================================
  Files          51      207     +156     
  Lines        7639    29909   +22270     
==========================================
+ Hits         7591    29309   +21718     
- Misses         48      600     +552     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maliasadi maliasadi added the ci:build_wheels Activate wheel building. label Apr 16, 2024
@maliasadi maliasadi requested review from mudit2812 and a team April 16, 2024 13:22
Copy link
Contributor

@vincentmr vincentmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If that works, no blocker from me. Thanks @maliasadi !

@multiphaseCFD
Copy link
Member

Thanks @maliasadi ! Do we also want to turn on mgpu tests?

@mudit2812
Copy link
Contributor

Device tests are still failing with LGPU and LK. Let's figure out if the issue is on the lightning side or PL side before merging this.

@maliasadi maliasadi added the ci:use-multi-gpu-runner Enable usage of Multi-GPU runner for this Pull Request label Apr 17, 2024
@maliasadi maliasadi merged commit bc9dbcb into master Apr 17, 2024
80 of 84 checks passed
@maliasadi maliasadi deleted the maa/fix-obs-serialize branch April 17, 2024 03:11
@tomlqc
Copy link
Contributor

tomlqc commented Apr 17, 2024

[sc-61588]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:build_wheels Activate wheel building. ci:use-multi-gpu-runner Enable usage of Multi-GPU runner for this Pull Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants