Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump kokkos versions. #578

Merged
merged 11 commits into from
Jan 3, 2024
Merged

Bump kokkos versions. #578

merged 11 commits into from
Jan 3, 2024

Conversation

vincentmr
Copy link
Contributor

@vincentmr vincentmr commented Dec 13, 2023

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:
Kokkos has a mix of 4.0.01 and 4.1.00 among the CMake files, CI, etc.

Description of the Change:
Use Kokkos 4.2.00 (latest) everywhere.

Benefits:
Up-to-date Kokkos and uniformized version.

Possible Drawbacks:

Related GitHub Issues:

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4290e60) 98.68% compared to head (1271f2b) 98.68%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #578   +/-   ##
=======================================
  Coverage   98.68%   98.68%           
=======================================
  Files         167      167           
  Lines       23959    23959           
=======================================
  Hits        23644    23644           
  Misses        315      315           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vincentmr vincentmr marked this pull request as ready for review December 14, 2023 12:22
@vincentmr vincentmr requested a review from a team December 14, 2023 12:23
@mlxd mlxd requested a review from maliasadi January 3, 2024 16:58
@mlxd mlxd merged commit 706a599 into master Jan 3, 2024
28 of 30 checks passed
@mlxd mlxd deleted the update/kokkos_4.2.00 branch January 3, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants