Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TestPyPI token for L-GPU wheels #575

Merged
merged 4 commits into from
Jan 3, 2024
Merged

Update TestPyPI token for L-GPU wheels #575

merged 4 commits into from
Jan 3, 2024

Conversation

mlxd
Copy link
Member

@mlxd mlxd commented Dec 12, 2023

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context: Updates the TestPyPI token for wheel build pushes to https://test.pypi.org/project/PennyLane-Lightning-GPU/ during development

Description of the Change: As above.

Benefits: Ensures the wheels are uploaded during development for quick testing.

Possible Drawbacks:

Related GitHub Issues:

@mlxd mlxd marked this pull request as ready for review December 12, 2023 17:07
Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for that!

@AmintorDusko AmintorDusko requested a review from a team December 12, 2023 17:09
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (489cff7) 98.42% compared to head (9c07b1b) 98.68%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #575      +/-   ##
==========================================
+ Coverage   98.42%   98.68%   +0.25%     
==========================================
  Files         144      167      +23     
  Lines       19052    23959    +4907     
==========================================
+ Hits        18752    23644    +4892     
- Misses        300      315      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@vincentmr vincentmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @mlxd .

@mlxd mlxd merged commit 4290e60 into master Jan 3, 2024
82 of 83 checks passed
@mlxd mlxd deleted the testpypi_token_lgpu branch January 3, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants