-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test coverage for LKokkos #485
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #485 +/- ##
==========================================
+ Coverage 93.04% 99.07% +6.02%
==========================================
Files 142 142
Lines 16278 16485 +207
==========================================
+ Hits 15146 16332 +1186
+ Misses 1132 153 -979
☔ View full report in Codecov by Sentry. |
…adjoint diff tests over kokkos_args.
* post release version bump * trigger CI --------- Co-authored-by: mlxd <mlxd@users.noreply.github.com> Co-authored-by: Vincent Michaud-Rioux <vincent.michaud-rioux@xanadu.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I notice that you are excluding some parts from the coverage checks.
Could you please elaborate on why?
pennylane_lightning/core/src/simulators/lightning_kokkos/StateVectorKokkos.hpp
Outdated
Show resolved
Hide resolved
… PL_ABORT coverage for SVKokkos named ops.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vincentmr
Just a few comments
...htning/core/src/simulators/lightning_kokkos/gates/tests/Test_StateVectorKokkos_Generator.cpp
Show resolved
Hide resolved
..._lightning/core/src/simulators/lightning_kokkos/gates/tests/Test_StateVectorKokkos_Param.cpp
Show resolved
Hide resolved
pennylane_lightning/core/src/simulators/lightning_qubit/gates/tests/Test_OpToMemberFuncPtr.cpp
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You did a nice work so far.
pennylane_lightning/core/src/simulators/lightning_kokkos/measurements/ExpValFunctors.hpp
Outdated
Show resolved
Hide resolved
pennylane_lightning/core/src/simulators/lightning_kokkos/measurements/MeasurementsKokkos.hpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Amintor Dusko <87949283+AmintorDusko@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work on that! I will approve it now, but please check if, without the coverage exclusion zone, we still pass the coverage checks. I think it is better not to add it, if not needed.
pennylane_lightning/core/src/simulators/lightning_kokkos/measurements/MeasurementsKokkos.hpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vincentmr
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests
directory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
.github/CHANGELOG.md
file, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
The LKokkos backend has lower coverage than PennyLane and LQubit. Codecov oftentimes fails as LKokkos' coverage does not meet the target.
Description of the Change:
GENERATE
(gateinverse
in particular to target theinverse
branch of functors), etc.GateOperation.hpp
start at1
(previously0
).::BEGIN
is introduced in a few places where it was assumed0
accordingly.Benefits:
Better test coverage.
Possible Drawbacks:
Related GitHub Issues: