Skip to content
This repository has been archived by the owner on Oct 27, 2023. It is now read-only.

Ensure active return check doesn't break CI #80

Merged
merged 4 commits into from
Aug 25, 2023
Merged

Conversation

vincentmr
Copy link
Contributor

@vincentmr vincentmr commented Aug 24, 2023

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@vincentmr vincentmr marked this pull request as ready for review August 24, 2023 20:38
Copy link
Member

@multiphaseCFD multiphaseCFD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @vincentmr .

Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for propagating this fix!

@vincentmr vincentmr merged commit 4d50382 into main Aug 25, 2023
28 checks passed
@vincentmr vincentmr deleted the active_ret_update branch August 25, 2023 13:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants