-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Hermitian Support for Finite-Shot Measurement Statistics #451
Open
multiphaseCFD
wants to merge
134
commits into
main
Choose a base branch
from
add_hermitian_shots
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
134 commits
Select commit
Hold shift + click to select a range
f0733e7
add more tests
multiphaseCFD 043bd0a
add lapack installation in ci
multiphaseCFD 862070f
Merge branch 'main' into add_hermitian_shots
multiphaseCFD 19b7976
update README.rst
multiphaseCFD 0025b72
use latest lightning branch
multiphaseCFD 4a4ba17
add frontend test
multiphaseCFD 8a7c804
quick fix
multiphaseCFD fc6c4f7
Merge branch 'main' into add_hermitian_shots
multiphaseCFD d2a369f
test against PL master branch
multiphaseCFD 0e563f2
Merge branch 'main' into add_hermitian_shots
multiphaseCFD 200e37d
Merge branch 'main' into add_hermitian_shots
multiphaseCFD 300ff89
test against master
multiphaseCFD 116b4b3
test with bbee87b Lightning
multiphaseCFD 7b74c10
Merge branch 'main' into add_hermitian_shots
multiphaseCFD 9db1bc1
update lightnng testing commit
multiphaseCFD e4426cd
wheel built with c9fba49
multiphaseCFD 0090442
test against 18231b5
multiphaseCFD d83f283
test against 18231b5
multiphaseCFD 93b6054
test with 8fa1367
multiphaseCFD 89da0ee
test against bec4b4e
multiphaseCFD 819e889
update workflow with py env and preinstalled scipy
multiphaseCFD 3df3c41
Merge branch 'main' into add_hermitian_shots
multiphaseCFD 35b5533
update yml work flow
multiphaseCFD a91c893
update check-catalyst
multiphaseCFD a868802
revert changes in catalyst
multiphaseCFD ed64d03
add scipy to build depencies
multiphaseCFD 4467024
test against 3f9b6a5
multiphaseCFD 4cff4fe
install scipy for lightning backend cpp test
multiphaseCFD 6999037
test against f71de3b
multiphaseCFD a8ac1bd
add scipy install for Catalyst-Runtime Build
multiphaseCFD 6fbf6e6
install scipy for Runtime Code Coverage
multiphaseCFD 89ab873
test against 8c1d354
multiphaseCFD 7c97813
test against 57be532
multiphaseCFD 11326af
add venv for ci
multiphaseCFD c8ded02
fix typo check-catalyst
multiphaseCFD c365730
add virtual env for Runtime Code Coverage
multiphaseCFD a687893
remove virtual env for frontend test
multiphaseCFD 4891bc5
frontend test only
multiphaseCFD bd305d9
frontend test only
multiphaseCFD 14fd068
frontend test only
multiphaseCFD d1343ac
Trigger CI
multiphaseCFD 68d52e2
test linux wheels build
multiphaseCFD 0b6b438
test 3.9 for debug
multiphaseCFD f1bb78d
update
multiphaseCFD 1ff7f1e
test against 97830a3
multiphaseCFD c71e26d
revert changes in linux wheels build
multiphaseCFD 4287394
test against a0db3f0
multiphaseCFD a1bcef8
add python3.10-12 test
multiphaseCFD 279e901
fix check-catalyst yaml
multiphaseCFD c00438b
use venv to install scipy
multiphaseCFD 8f87ac4
fix typo
multiphaseCFD 1115b02
fix typo
multiphaseCFD 7444ee4
use py3.10 for test
multiphaseCFD c3f9b36
revert changes in Frontend tests gcc workflow
multiphaseCFD eb04c77
add scipy to gcc frontend tests
multiphaseCFD d53517b
test for lightning frontend
multiphaseCFD a32ccdf
target at 5bcae01
multiphaseCFD 2abcd3d
install scipy with python in virtual env
multiphaseCFD 7c5ae40
fix path
multiphaseCFD 9bb29e1
force install scipy to default venv
multiphaseCFD 343b2ba
trigger ci
maliasadi b4b553a
Update lq tags
maliasadi 9d85530
Add changelog
maliasadi 8aa5a04
Update tests
maliasadi 90ad52f
Merge branch 'main' into add_hermitian_shots
maliasadi 934c80b
trigger ci
maliasadi 5c4d9a2
Update check-catalyst
maliasadi 7195af7
Merge branch 'main' into add_hermitian_shots
multiphaseCFD 6c1ae4b
avoid explicitly install scipy
multiphaseCFD 490f7c2
enable_lapack for macos x86-64 wheel
multiphaseCFD d999dd3
update workflow
multiphaseCFD 63f6bb9
update check-catalyst
multiphaseCFD a35da01
remove blanks
multiphaseCFD ba4bae5
ensure scipy is installed
multiphaseCFD 7abb4ea
Set up Python step
maliasadi 4fe8806
test against e91975e
multiphaseCFD b2ec3b5
test against c813e21
multiphaseCFD 64f505d
test against 951e231
multiphaseCFD b2ee43d
test def8a26
multiphaseCFD 5922f21
add pybind_Dir
multiphaseCFD cc427d1
test
multiphaseCFD cd56be7
Merge branch 'main' into add_hermitian_shots
multiphaseCFD ea4fbf7
add venv
multiphaseCFD ade3aa2
quick test
multiphaseCFD cf832ff
add pybind11 as dependency
multiphaseCFD d089593
check python
multiphaseCFD b401d64
python3->python
multiphaseCFD f8e106c
install scipy
multiphaseCFD 3f9fb3c
tests
multiphaseCFD d94ec96
remove grep
multiphaseCFD ccecc1f
add lit
multiphaseCFD 921dee1
enable_lapack
multiphaseCFD 165f9da
llvm-lit->lit
multiphaseCFD bf9492d
specify python when make frontend
multiphaseCFD 12df432
python_executable -> "python"
multiphaseCFD f2a66e1
change python
multiphaseCFD 7f7da4f
update make coverage-frontend
multiphaseCFD 71ec99b
install attrs
multiphaseCFD 017c567
install --upgrade attrs
multiphaseCFD 05a7052
test against dd3bafb
multiphaseCFD 2fab1e2
Merge branch 'main' into add_hermitian_shots
multiphaseCFD 79f5e19
Merge branch 'main' into add_hermitian_shots
multiphaseCFD 71af0cf
enable_lapack
multiphaseCFD 832657c
test against recent changes
multiphaseCFD 7de6965
Merge branch 'main' into add_hermitian_shots
multiphaseCFD 66720a5
test against 48da2c2
multiphaseCFD d84f9ba
test against dcb2e79
multiphaseCFD f58449f
Merge branch 'main' into add_hermitian_shots
multiphaseCFD 27b21c9
test against 5097351
multiphaseCFD f8fb90c
test against b1b2d60
multiphaseCFD 9c694d0
test against 6c50b77
multiphaseCFD 9b73fd0
revert some changes
multiphaseCFD 504f9fe
test against 352e7d1
multiphaseCFD e9be89a
test for runtime-code-cov
multiphaseCFD 0decf35
install scipy
multiphaseCFD bc64e1a
build python venv
multiphaseCFD 41b7d85
update check-catalyst
multiphaseCFD 0b0c0c4
quick test
multiphaseCFD 17a61e8
update
multiphaseCFD b5cbc1a
check
multiphaseCFD 04dca15
test against 2355a0a
multiphaseCFD 02be098
update Runtime Code Coverage
multiphaseCFD 708068d
test against 7d47297
multiphaseCFD ddfaba9
test against a599094
multiphaseCFD 360607c
test against 05d9e4d
multiphaseCFD 030f472
test against a3bef4c
multiphaseCFD 3296112
Add PYTHON_LIBRARY option
multiphaseCFD cdd02b4
quick fix
multiphaseCFD d9c3921
test against 35c3bd4
multiphaseCFD 25fe0b7
test 07626e5
multiphaseCFD b471aef
test against 4b40406
multiphaseCFD c0b1564
test against 4b40406
multiphaseCFD e53c243
default USE_PYTHON_HEADERS ON for lightning backend
multiphaseCFD 151a4b8
test against 77a8b21
multiphaseCFD File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,6 +6,7 @@ pip>=22.3 | |
numpy<2 | ||
pybind11>=2.8.0 | ||
PyYAML | ||
scipy | ||
|
||
# formatting/linting | ||
black | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here (and other places) as well I would be hesitant to install
scipy
manually. There should be a clear strategy about how we are bringing in thescipy
dependency.If a built-time dependency, it can be added to the relevant build scripts in the corresponding setup step.
If a run-time dependency, it should probably only be placed in one location: the
setup.py
package requirements. However, if the dependency is brought in by lightning rather than Catalyst directly, you would think the lightning package requirements already contain ascipy
entry.