Skip to content

Refactoring QEC Tablegen into QECOps and QECDialect #2253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Refactoring QEC Tablegen into QECOps and QECDialect #2253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c900667
Separating QEC tablegen files
lazypanda10117 Dec 1, 2025
8307024
Removing unused imports
lazypanda10117 Dec 1, 2025
f99d9e8
Removing unused imports
lazypanda10117 Dec 1, 2025
7d68da5
Removing unused imports
lazypanda10117 Dec 1, 2025
81abb1a
Changelog
lazypanda10117 Dec 1, 2025
b288a04
Merge branch 'main' into lazypand10117/update-qec-tablegen
lazypanda10117 Dec 1, 2025
95b4e65
updaing doc cmake
lazypanda10117 Dec 1, 2025
af6ea85
Fixing build issues
lazypanda10117 Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions doc/releases/changelog-dev.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,11 @@
that sum to identity.
[(#2224)](https://github.com/PennyLaneAI/catalyst/pull/2224)


* Refactor QEC tablegen files to separate QEC operations into a new `QECOp.td` file
[(#2253](https://github.com/PennyLaneAI/catalyst/pull/2253)


<h3>Documentation 📝</h3>

* A typo in the code example for :func:`~.passes.ppr_to_ppm` has been corrected.
Expand Down
7 changes: 4 additions & 3 deletions mlir/include/QEC/IR/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
add_mlir_dialect(QECDialect qec)
add_mlir_dialect(QECOps qec)
add_mlir_interface(QECOpInterfaces)
add_mlir_doc(QECDialect QECDialect QEC/ -gen-dialect-doc -gen-op-doc)
add_mlir_doc(QECDialect QECDialect QEC/ -gen-dialect-doc -dialect qec)
add_mlir_doc(QECOps QECOps QEC/ -gen-op-doc)
add_mlir_doc(QECOpInterfaces QECOpInterfaces QEC/ -gen-op-interface-docs)

set(LLVM_TARGET_DEFINITIONS QECDialect.td)
set(LLVM_TARGET_DEFINITIONS QECOps.td)
mlir_tablegen(QECEnums.h.inc -gen-enum-decls)
mlir_tablegen(QECEnums.cpp.inc -gen-enum-defs)
mlir_tablegen(QECAttributes.h.inc -gen-attrdef-decls)
Expand Down
21 changes: 3 additions & 18 deletions mlir/include/QEC/IR/QECDialect.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,31 +14,23 @@

#pragma once

#include "mlir/Bytecode/BytecodeOpInterface.h"
#include "mlir/IR/BuiltinTypes.h"
#include "mlir/IR/Dialect.h"
#include "mlir/IR/OpDefinition.h"
#include "mlir/IR/PatternMatch.h"
#include "mlir/Interfaces/ControlFlowInterfaces.h"
#include "mlir/Interfaces/SideEffectInterfaces.h"

#include "QEC/IR/QECOpInterfaces.h"

//===----------------------------------------------------------------------===//
// QEC dialect declarations.
//===----------------------------------------------------------------------===//

#include "QEC/IR/QECDialectDialect.h.inc"
#include "QEC/IR/QECOpsDialect.h.inc"

//===----------------------------------------------------------------------===//
// QEC type declarations.
//===----------------------------------------------------------------------===//

#define GET_TYPEDEF_CLASSES
#include "QEC/IR/QECDialectTypes.h.inc"
#include "QEC/IR/QECOpsTypes.h.inc"

//===----------------------------------------------------------------------===//
// QEC enum definitions.
// QEC enum declarations.
//===----------------------------------------------------------------------===//

#include "QEC/IR/QECEnums.h.inc"
Expand All @@ -49,10 +41,3 @@

#define GET_ATTRDEF_CLASSES
#include "QEC/IR/QECAttributes.h.inc"

//===----------------------------------------------------------------------===//
// QEC ops declarations.
//===----------------------------------------------------------------------===//

#define GET_OP_CLASSES
#include "QEC/IR/QECDialect.h.inc"
Loading