feat: add ConstructCircuitDAG director pattern
#2214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrijapau
changed the title
CircuitDAGAnalysisPass pass
andrijapau
changed the title
CircuitDAGAnalysisPass passCircuitDAGAnalysisPass
andrijapau
commented
Nov 20, 2025
frontend/catalyst/python_interface/visualization/circuit_dag_analysis_pass.py
Outdated
Show resolved
Hide resolved
andrijapau
commented
Nov 20, 2025
frontend/catalyst/python_interface/visualization/circuit_dag_analysis_pass.py
Outdated
Show resolved
Hide resolved
andrijapau
commented
Nov 20, 2025
frontend/catalyst/python_interface/visualization/circuit_dag_analysis_pass.py
Outdated
Show resolved
Hide resolved
andrijapau
commented
Nov 20, 2025
frontend/catalyst/python_interface/visualization/circuit_dag_analysis_pass.py
Outdated
Show resolved
Hide resolved
andrijapau
commented
Nov 20, 2025
frontend/catalyst/python_interface/visualization/circuit_dag_analysis_pass.py
Outdated
Show resolved
Hide resolved
…lder.py Co-authored-by: Mehrdad Malek <39844030+mehrdad2m@users.noreply.github.com>
…lder.py Co-authored-by: Mehrdad Malek <39844030+mehrdad2m@users.noreply.github.com>
…_dag_builder.py Co-authored-by: Mehrdad Malek <39844030+mehrdad2m@users.noreply.github.com>
…lder.py Co-authored-by: Mehrdad Malek <39844030+mehrdad2m@users.noreply.github.com>
Co-authored-by: Mehrdad Malek <39844030+mehrdad2m@users.noreply.github.com>
mudit2812
reviewed
Nov 26, 2025
frontend/catalyst/python_interface/visualization/construct_circuit_dag.py
Show resolved
Hide resolved
andrijapau
changed the title
ConstructCircuitDAG utility ConstructCircuitDAG director pattern
Base automatically changed from
fix/upgrade-dag-builders
to
feature/graph-visualization
November 26, 2025 20:56
mehrdad2m
reviewed
Nov 28, 2025
Contributor
mehrdad2m
left a comment
mehrdad2m
left a comment
There was a problem hiding this comment.
Thanks @andrijapau, Looks very good. Just some comments:
frontend/catalyst/python_interface/visualization/construct_circuit_dag.py
Outdated
Show resolved
Hide resolved
frontend/test/pytest/python_interface/visualization/test_construct_circuit_dag.py
Outdated
Show resolved
Hide resolved
frontend/catalyst/python_interface/visualization/construct_circuit_dag.py
Show resolved
Hide resolved
…cuit_dag.py Co-authored-by: Mehrdad Malek <39844030+mehrdad2m@users.noreply.github.com>
mehrdad2m
approved these changes
Nov 28, 2025
mudit2812
approved these changes
Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This utility is used to traverse the IR and then use the DAGBuilder to generate a DAG to be visualized.
[sc-103458]