-
Notifications
You must be signed in to change notification settings - Fork 59
Use transform pass name #2206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
albi3ro
wants to merge
33
commits into
main
Choose a base branch
from
use-transform-pass-name
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Use transform pass name #2206
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
53df1bc
use pass name from transform
albi3ro cf01501
some udpates
albi3ro a08905b
make backwards compatible
albi3ro 0cb9476
messed from plxpr up somehow
albi3ro dd3a655
Merge branch 'main' into pass-pipeline-transform-program
albi3ro 3b2c5b8
more polishing
albi3ro 42b5052
Merge branch 'main' into pass-pipeline-transform-program
albi3ro e885b91
some test fixes
albi3ro 5c99bba
fix failing test
albi3ro ffedfe4
see if that fixes the failure
albi3ro 77a211d
oops
albi3ro c738102
Merge branch 'main' into pass-pipeline-transform-program
albi3ro a1abd24
[skip ci] starting to test
albi3ro b6441bf
try using transform instead of passes
albi3ro 838e45f
switch passes to being tranfsorms
albi3ro b2ca54d
update apply_pass and apply_pass_plugin
albi3ro f76ac1b
update apply_pass and apply_pass_plugin
albi3ro ded40ef
Merge branch 'main' into pass-pipeline-transform-program
albi3ro 8b045d0
adding in some tests
albi3ro ed528ba
black and isort
albi3ro 80c4a33
Merge branch 'main' into pass-pipeline-transform-program
albi3ro ec38c77
minor fixes
albi3ro d6477f5
Merge branch 'pass-pipeline-transform-program' into use-transform-pas…
albi3ro 4771069
remove tests
albi3ro b5595af
Apply suggestion from @albi3ro
albi3ro 579c27b
leave pipeline test in
albi3ro 068e30b
Merge branch 'use-transform-pass-name' of https://github.com/PennyLan…
albi3ro e01158e
update name of cancel_inverses in test
albi3ro d37d89b
Try to fix the lit test again
albi3ro 3586dd3
delete test files
albi3ro 9d167c6
Merge branch 'main' into use-transform-pass-name
albi3ro 80e149e
unpin pl branch
albi3ro 3c8734e
Merge branch 'use-transform-pass-name' of https://github.com/PennyLan…
albi3ro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just switching to using a guard clause here. No actual code changes, but made it easier to scan the source code and see what was happening.