[Gridsynth 1] Gridsynth decomposition #2140

josephleekl · 2025-10-21T22:12:36Z

Context:
This is the first of 2 PRs to implement the 'Gridsynth' pass in Catalyst. (Second PR). This PR only contains the MLIR pass itself, and a dummy implementation of the actual runtime discretization function in order to test the data transfer between the MLIR and the C++ runtime. The actual discretization runtime, along with python tests, will be part of the next PR.

This branch needs to be used in conjunction with the rs-decomp branch in PennyLane.

To test this:

import pennylane as qml
from functools import partial

qml.capture.enable()

@qml.qjit(verbose=True, keep_intermediate=True)
@partial(qml.transforms.gridsynth, epsilon=0.12345, ppr_basis=False)
@qml.qnode(qml.device("null.qubit", wires=1))
def circuit(x):
    qml.RZ(x, 0)
    return qml.expval(qml.Z(0))

x = 1.1
print(circuit(x))

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

[sc-102150]

paul0403 · 2025-11-27T19:23:37Z

.dep-versions

 # For a custom PL version, update the package version here and at
 # 'doc/requirements.txt'
-pennylane=0.44.0.dev31
+pennylane=0.44.0.dev37


Once the PL PR is merged, let's update to that dev version

paul0403 · 2025-11-27T19:23:44Z

doc/requirements.txt

 pennylane-lightning-kokkos==0.44.0-dev11
 pennylane-lightning==0.44.0-dev11
-pennylane==0.44.0.dev31
+git+https://github.com/PennyLaneAI/pennylane.git@rs-decomp


runtime/lib/RSDecompRuntime/RSDecomp.cpp

mlir/test/Quantum/Gridsynth.mlir

mlir/lib/Quantum/Transforms/GridsynthPatterns.cpp

paul0403 · 2025-11-27T20:52:22Z

mlir/lib/Quantum/Transforms/GridsynthPatterns.cpp

+    auto getSizeType =
+        rewriter.getFunctionType({f64Type, f64Type, i1Type}, {rewriter.getIndexType()});
+    auto getSizeFunc =
+        catalyst::ensurefuncOrDeclare(rewriter, func, "rs_decomposition_get_size", getSizeType);


Do you know what is adding the _0 to the names? 🤔 doesn't seem to show up in the unit test for the pass, but seems like something in the end-to-end pipeline is adding it.

Apparantly it's the --inline-nested-module pass.

frontend/catalyst/passes/builtin_passes.py

mlir/lib/Catalyst/Utils/EnsureFunctionDeclaration.cpp

dime10 · 2025-11-28T21:27:32Z

runtime/lib/RSDecompRuntime/RSDecomp.cpp

+ * Note: I have tried to use `MemRefT_int64_1d` directly from Types.h, but ran into
+ * C++ ABI errors (on macOS) leading to segmentation faults. Thus, we manually unpack the memref
+ * here.


I think the reason might be that we usually pass a pointer to the memref descriptor, precisely to avoid abi issues with how structs are passed (apparently those can differ). We typically just use stack memory for this.

But since your use case is limited with a small signature, the direct approach might work well :)

mlir/lib/Quantum/Transforms/GridsynthPatterns.cpp

runtime/lib/RSDecompRuntime/RSDecomp.cpp

sengthai

I appreciate this PR! @josephleekl
Here is part 1 of the review.

frontend/catalyst/passes/builtin_passes.py

mlir/include/Quantum/Transforms/Passes.td

mlir/lib/Quantum/Transforms/gridsynth.cpp

sengthai · 2025-11-28T22:18:25Z

mlir/lib/Quantum/Transforms/GridsynthPatterns.cpp

+
+void populateGridsynthPatterns(RewritePatternSet &patterns, double epsilon, bool pprBasis)
+{
+    patterns.add<DecomposeCustomOpPattern>(patterns.getContext(), epsilon, pprBasis);


Could we include decomposing PPRotationArbitraryOp (e.g, qec.ppr.arbitrary ["Z"](%const) %q0,) in this PR as well? https://github.com/PennyLaneAI/catalyst/blob/3eefa0088455a088841631e80f621f89e717c22d/mlir/include/QEC/IR/QECDialect.td#L354C1-L355C1

mlir/lib/Quantum/Transforms/GridsynthPatterns.cpp

Co-authored-by: Sengthai Heng <sengthai37@gmail.com>

josephleekl added 12 commits October 21, 2025 22:12

rs-decomp

7d393f7

update

6189426

update

b3be643

update

ba25e5a

update

2ab894f

update

1947de4

update

45a64b7

remove unnecessary include

5402851

update

8748550

Merge branch 'main' into rs-decomp

e49db23

dummy impl

79d6712

remove debug

b10d42c

josephleekl changed the title ~~RS decomposition~~ [WIP] Gridsynth decomposition Oct 29, 2025

clean

328a0be

josephleekl changed the title ~~[WIP] Gridsynth decomposition~~ [WIP - Gridsynth 1] Gridsynth decomposition Oct 30, 2025

josephleekl and others added 15 commits November 5, 2025 14:45

decomp takes theta and epsilon

4648c0e

Merge branch 'main' into rs-decomp

d3635d1

Merge branch 'main' into rs-decomp

b7e4f75

support RZ and updated frontend

fbde78a

format

9114b32

Merge branch 'main' into rs-decomp

04fb5af

fix sourceop has more than one input/output

e5f2bf4

allow direct lowering to ppr

c3cd186

Merge branch 'main' into rs-decomp

b929fe5

format

828c179

clean up

5caaa53

fix mac segfault

8fb7605

extractop allow dynamic/static indices

f29c9ba

Merge branch 'main' into rs-decomp

6537d4f

change rsdecomposition to gridsynth

2afb190

josephleekl requested review from lazypanda10117, maliasadi and sengthai November 25, 2025 19:58

josephleekl changed the title ~~[WIP - Gridsynth 1] Gridsynth decomposition~~ [Gridsynth 1] Gridsynth decomposition Nov 25, 2025

josephleekl requested a review from AntonNI8 November 25, 2025 21:27

fix phaseshift phase

d8be26a

paul0403 reviewed Nov 27, 2025

View reviewed changes

lazypanda10117 reviewed Nov 27, 2025

View reviewed changes

frontend/catalyst/passes/builtin_passes.py Show resolved Hide resolved

mlir/lib/Catalyst/Utils/EnsureFunctionDeclaration.cpp Outdated Show resolved Hide resolved

paul0403 mentioned this pull request Nov 28, 2025

Do not rename external func decls during --inline-nested-modules #2244

Open

dime10 reviewed Nov 28, 2025

View reviewed changes

mlir/lib/Quantum/Transforms/GridsynthPatterns.cpp Outdated Show resolved Hide resolved

dime10 reviewed Nov 28, 2025

View reviewed changes

runtime/lib/RSDecompRuntime/RSDecomp.cpp Outdated Show resolved Hide resolved

review comments

17a0778

sengthai reviewed Nov 28, 2025

View reviewed changes

paul0403 and others added 13 commits December 1, 2025 17:47

isExternal -> getCallableRegion

80cabdf

Apply suggestions from code review

18dd269

Co-authored-by: Sengthai Heng <sengthai37@gmail.com>

Merge branch 'main' into rs-decomp

fb2c012

code review

ea84709

Add estimated_iterations attribute to forOp in GridsynthPatterns

2977e98

use heap alloc and add doc

067a398

review comments - template declarefunc, alloc

736b357

break up big getOrCreateDecompositionFunc function

b454fbe

remove unnecessary using namespace

9ef0342

Merge branch 'main' into rs-decomp

e8cc971

add frontend lit test

22acc0d

codefactor

f4aeb50

use size_t instead of int64_t for runtime func

a28ae7f

josephleekl requested review from paul0403 and sengthai December 2, 2025 23:07

update test

b78d2b7

[Gridsynth 1] Gridsynth decomposition #2140

Are you sure you want to change the base?

[Gridsynth 1] Gridsynth decomposition #2140

Uh oh!

Conversation

josephleekl commented Oct 21, 2025 • edited by paul0403 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

paul0403 Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

paul0403 Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

paul0403 Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

paul0403 Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

paul0403 Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dime10 Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sengthai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sengthai Nov 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

josephleekl commented Oct 21, 2025 •

edited by paul0403

Loading