Migrate the entire bufferization pipeline to one-shot bufferization #1751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead, the mem write interface can copy for us, and even decide when a copy is needed!
…e_gradient_dialect
llvm/llvm-project#107109 The core dialect conversion no longer tries to materialize ops on the fly during conversion, but rather inserts unrealized conversion casts to be safe, and removes these inverse cast pairs later after the entire conversion is done. The old analysis is removed. Personally I think this is fine, as we end our pipeline with --reconcil-unrealized-casts already. Changes: Catalyst/ConversionTest.mlir and Catalyst/MemrefLoadStoreLoweringTBAA.mlir: changing op order Quantum/ConversionTest.mlir: changing op order; adding two unrealized conversion cast pairs Gradient/ConversionTest.mlir: 5 unused Values are removed
…e_gradient_dialect
paul0403
commented
May 21, 2025
…e_gradient_dialect
…dialect' into paul0403/one-shot-bufferize-final
dime10
reviewed
May 22, 2025
|
Since this one updates LLVM, let's check the wheels before merging. I will also clean the CI cache under this llvm commit before checking just for absolute certainty. |
paul0403
added
author:build-wheels
paul0403
removed
reviewer:require-wheels
paul0403
added a commit
that referenced
this pull request
May 28, 2025
1. Moving ops around due to random ordering updates 2. Revert the inserted unrealized_conversion_casts in #1751 3. llvm.mlir.undef is deprecated, use llvm.mlir.poison instead llvm/llvm-project#125629
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
This work is based on #1027.
Now that we have migrated all the individual dialects, we should migrate the entire bufferization pipeline.
The
Quantumdialect was migrated in #1686 .The
Catalystdialect was migrated in #1708 .The
Gradientdialect was migrated in #1740 .See more context in #1027.
Upstream changes in llvm were required for this bufferization update. As a result, the llvm version and mlir-hlo version were updated to
These are the versions tracked by jax 0.4.32.
These are the earliest jax-tagged versions with complete upstream bufferization changes.
Related GitHub Issues:
[sc-71487]