-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated pennylane code #1168
Conversation
Proof of success here. The reference to |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1168 +/- ##
=======================================
Coverage 97.86% 97.86%
=======================================
Files 76 76
Lines 10807 10808 +1
Branches 1281 1281
=======================================
+ Hits 10576 10577 +1
Misses 179 179
Partials 52 52 ☔ View full report in Codecov by Sentry. |
[sc-73914] |
What do you mean by this? Ideally we don't want warnings in our tests either :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are broadcast templates being deprecated? Why don't we just remove the tests?
@dime10 The warning is coming from the testing of the
@erick-xanadu , I think it makes sense to keep the tests there. While |
As name says.
I've also temporarily added a warning filter to promoteRemoved.PennyLaneDeprecationWarning
s to errors. I'll remove it once CI passes in this PR.