Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated pennylane code #1168

Merged
merged 11 commits into from
Oct 2, 2024
Merged

Remove deprecated pennylane code #1168

merged 11 commits into from
Oct 2, 2024

Conversation

mudit2812
Copy link
Contributor

@mudit2812 mudit2812 commented Oct 1, 2024

As name says. I've also temporarily added a warning filter to promote PennyLaneDeprecationWarnings to errors. I'll remove it once CI passes in this PR. Removed.

@mudit2812
Copy link
Contributor Author

Proof of success here. The reference to qml._device.DeviceError has now been fixed as well, and the BasisStatePreparation warning is coming from tests, not from catalyst, so I'm leaving it as is. Going to remove the warning to error promotion now.

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.86%. Comparing base (9a3e64b) to head (2d2a7e9).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1168   +/-   ##
=======================================
  Coverage   97.86%   97.86%           
=======================================
  Files          76       76           
  Lines       10807    10808    +1     
  Branches     1281     1281           
=======================================
+ Hits        10576    10577    +1     
  Misses        179      179           
  Partials       52       52           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mudit2812
Copy link
Contributor Author

[sc-73914]

@dime10
Copy link
Collaborator

dime10 commented Oct 2, 2024

and the BasisStatePreparation warning is coming from tests, not from catalyst, so I'm leaving it as is. Going to remove the warning to error promotion now.

What do you mean by this? Ideally we don't want warnings in our tests either :)

Copy link
Contributor

@erick-xanadu erick-xanadu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are broadcast templates being deprecated? Why don't we just remove the tests?

@mudit2812
Copy link
Contributor Author

mudit2812 commented Oct 2, 2024

and the BasisStatePreparation warning is coming from tests, not from catalyst, so I'm leaving it as is. Going to remove the warning to error promotion now.

What do you mean by this? Ideally we don't want warnings in our tests either :)

@dime10 The warning is coming from the testing of the BasisStatePreparation template, which is deprecated. The catalyst codebase doesn't create BasisStatePreparation anywhere except for that one test. I'll add a warning suppression regardless.

Are broadcast templates being deprecated? Why don't we just remove the tests?

@erick-xanadu , I think it makes sense to keep the tests there. While broadcast is deprecated, it's still present, so better safe than sorry.

@mudit2812 mudit2812 merged commit a013f12 into main Oct 2, 2024
42 checks passed
@mudit2812 mudit2812 deleted the 0.39-deprecations branch October 2, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants